Skip to content

chore: update AGENTS.md with correct Flutter version and test docs#56

Open
SunkenInTime wants to merge 1 commit intomainfrom
cursor/development-environment-setup-ad2e
Open

chore: update AGENTS.md with correct Flutter version and test docs#56
SunkenInTime wants to merge 1 commit intomainfrom
cursor/development-environment-setup-ad2e

Conversation

@SunkenInTime
Copy link
Owner

Summary

Updates AGENTS.md with corrections discovered during development environment setup:

  • Flutter version: Fixed from 3.38.4 to 3.41.1 to match the actual .fvmrc file.
  • Tests: Corrected the claim that "no automated tests exist" — there are 24 test files with ~147 passing tests (and ~6 pre-existing failures).
  • Lint: Updated lint expectation from "~70 warnings/infos" to the actual state (a handful of prefer_const_constructors infos, no errors).

No code changes — only documentation corrections.

Open in Web Open in Cursor 

Co-authored-by: Dara Adedeji <SunkenInTime@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Mar 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
icarus Ready Ready Preview, Comment Mar 21, 2026 5:35pm

@SunkenInTime SunkenInTime marked this pull request as ready for review March 21, 2026 19:25
Copilot AI review requested due to automatic review settings March 21, 2026 19:25
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 21, 2026

Greptile Summary

This PR corrects three factual inaccuracies in AGENTS.md that were discovered during dev environment setup. All three changes have been verified against the repository's source of truth:

  • Flutter version (3.38.43.41.1): Confirmed correct — the .fvmrc file contains "flutter": "3.41.1".
  • Tests: The "no automated tests exist" claim is replaced with accurate counts — the test/ directory contains exactly 24 *_test.dart files, matching the stated number.
  • Lint: The lint expectation is narrowed from "~70 pre-existing warnings/infos" to "a handful of prefer_const_constructors infos, no errors", which is a more useful guide for agents running fvm flutter analyze.

No code changes are included. The documentation is now consistent with the actual repository state.

Confidence Score: 5/5

  • This PR is safe to merge — it is a documentation-only change with all facts verified against the repository.
  • All three corrections are factually accurate (Flutter version confirmed by .fvmrc, test file count confirmed by directory listing), there are no code changes, and the update makes AGENTS.md more reliable for future agents and contributors.
  • No files require special attention.

Important Files Changed

Filename Overview
AGENTS.md Documentation-only corrections: Flutter version updated from 3.38.4 to 3.41.1 (verified against .fvmrc), test section corrected from "no tests" to 24 files/~147 passes/~6 failures, and lint expectation narrowed from ~70 warnings to a handful of prefer_const_constructors infos.

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant FVM as FVM (Flutter 3.41.1)
    participant BR as build_runner
    participant Test as flutter test
    participant Analyze as flutter analyze

    Dev->>FVM: fvm flutter run -d linux
    Dev->>BR: fvm flutter pub run build_runner build --delete-conflicting-outputs
    BR-->>Dev: regenerates .g.dart / .freezed.dart

    Dev->>Test: fvm flutter test
    Test-->>Dev: ~147 passes, ~6 pre-existing failures (24 test files)

    Dev->>Analyze: fvm flutter analyze
    Analyze-->>Dev: handful of prefer_const_constructors infos, no errors

    Dev->>FVM: fvm flutter build linux --debug
    FVM-->>Dev: build/linux/x64/debug/bundle/icarus
Loading

Last reviewed commit: "Update AGENTS.md: fi..."

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates repository agent/setup documentation to reflect the current Flutter toolchain and the actual state of tests/linting in the project.

Changes:

  • Correct Flutter version reference to match .fvmrc (3.41.1).
  • Update testing guidance to reflect that automated tests exist and currently have some known failures.
  • Update lint expectations to reflect current analyzer output (info-level diagnostics only).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- **Code generation.** After changing Hive models, Riverpod providers, or JSON-serializable classes, regenerate with: `fvm flutter pub run build_runner build --delete-conflicting-outputs`.
- **No automated tests exist** in this codebase. `flutter test` will find nothing.
- **Lint.** `fvm flutter analyze` — expect ~70 pre-existing warnings/infos (unused imports, deprecated APIs). No errors.
- **Tests.** `fvm flutter test` — 24 test files exist. Expect ~147 passes and ~6 pre-existing failures.
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exact test outcome counts ("~147 passes" / "~6 pre-existing failures") are likely to drift as tests are added/removed or flakes are fixed. Consider phrasing this more durably (e.g., "a large suite of tests exists; a few known failures remain") and/or listing the specific known failing tests so readers can quickly distinguish regressions from expected failures.

Suggested change
- **Tests.** `fvm flutter test`24 test files exist. Expect ~147 passes and ~6 pre-existing failures.
- **Tests.** `fvm flutter test`a substantial automated test suite exists; expect most tests to pass, with a small number of known pre-existing failures that should be distinguished from new regressions.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants