chore: update AGENTS.md with correct Flutter version and test docs#56
chore: update AGENTS.md with correct Flutter version and test docs#56SunkenInTime wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: Dara Adedeji <SunkenInTime@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR corrects three factual inaccuracies in
No code changes are included. The documentation is now consistent with the actual repository state. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant FVM as FVM (Flutter 3.41.1)
participant BR as build_runner
participant Test as flutter test
participant Analyze as flutter analyze
Dev->>FVM: fvm flutter run -d linux
Dev->>BR: fvm flutter pub run build_runner build --delete-conflicting-outputs
BR-->>Dev: regenerates .g.dart / .freezed.dart
Dev->>Test: fvm flutter test
Test-->>Dev: ~147 passes, ~6 pre-existing failures (24 test files)
Dev->>Analyze: fvm flutter analyze
Analyze-->>Dev: handful of prefer_const_constructors infos, no errors
Dev->>FVM: fvm flutter build linux --debug
FVM-->>Dev: build/linux/x64/debug/bundle/icarus
Last reviewed commit: "Update AGENTS.md: fi..." |
There was a problem hiding this comment.
Pull request overview
Updates repository agent/setup documentation to reflect the current Flutter toolchain and the actual state of tests/linting in the project.
Changes:
- Correct Flutter version reference to match
.fvmrc(3.41.1). - Update testing guidance to reflect that automated tests exist and currently have some known failures.
- Update lint expectations to reflect current analyzer output (info-level diagnostics only).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - **Code generation.** After changing Hive models, Riverpod providers, or JSON-serializable classes, regenerate with: `fvm flutter pub run build_runner build --delete-conflicting-outputs`. | ||
| - **No automated tests exist** in this codebase. `flutter test` will find nothing. | ||
| - **Lint.** `fvm flutter analyze` — expect ~70 pre-existing warnings/infos (unused imports, deprecated APIs). No errors. | ||
| - **Tests.** `fvm flutter test` — 24 test files exist. Expect ~147 passes and ~6 pre-existing failures. |
There was a problem hiding this comment.
The exact test outcome counts ("~147 passes" / "~6 pre-existing failures") are likely to drift as tests are added/removed or flakes are fixed. Consider phrasing this more durably (e.g., "a large suite of tests exists; a few known failures remain") and/or listing the specific known failing tests so readers can quickly distinguish regressions from expected failures.
| - **Tests.** `fvm flutter test` — 24 test files exist. Expect ~147 passes and ~6 pre-existing failures. | |
| - **Tests.** `fvm flutter test` — a substantial automated test suite exists; expect most tests to pass, with a small number of known pre-existing failures that should be distinguished from new regressions. |
Summary
Updates
AGENTS.mdwith corrections discovered during development environment setup:3.38.4to3.41.1to match the actual.fvmrcfile.prefer_const_constructorsinfos, no errors).No code changes — only documentation corrections.