Skip to content

Drop refs to oxlint rules that no longer exist#3053

Merged
Crabcyborg merged 2 commits intomasterfrom
drop_ref_to_oxlint_rule
Mar 31, 2026
Merged

Drop refs to oxlint rules that no longer exist#3053
Crabcyborg merged 2 commits intomasterfrom
drop_ref_to_oxlint_rule

Conversation

@Crabcyborg
Copy link
Copy Markdown
Contributor

@Crabcyborg Crabcyborg commented Mar 31, 2026

It's failing in an open PR on new versions. Some rules appear to be removed.

Failed to parse oxlint configuration file.

  × Rule 'no-for-loop' not found in plugin 'unicorn'
  │ 
  │ Rule 'prevent-abbreviations' not found in plugin 'unicorn'
  │ 
  │ Rule 'prop-types' not found in plugin 'react'

Summary by CodeRabbit

  • Chores
    • Updated linting configuration by re-enabling three code quality rules: prop type validation, naming convention checks, and loop pattern enforcement.

@Crabcyborg Crabcyborg changed the title Drop ref to oxlint rule Drop ref to oxlint rules that no longer exist Mar 31, 2026
@Crabcyborg Crabcyborg changed the title Drop ref to oxlint rules that no longer exist Drop refs to oxlint rules that no longer exist Mar 31, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

📝 Walkthrough

Walkthrough

The .oxlintrc.json configuration file was updated to remove explicit disabling entries for three lint rules: react/prop-types, unicorn/prevent-abbreviations, and unicorn/no-for-loop. These rules will now follow default behavior instead of being explicitly turned off.

Changes

Cohort / File(s) Summary
Linting Configuration
.oxlintrc.json
Removed disabling entries for three lint rules: react/prop-types, unicorn/prevent-abbreviations, and unicorn/no-for-loop. These rules will now revert to their default behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Three lint rules hop free from their cage,
No more abbreviations banned from the page,
Prop-types and loops dance in the light,
Configuration cleaned up, everything right—
The code bounces onward, fluffy and bright! 🌿

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing references to oxlint rules that no longer exist from the configuration file.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch drop_ref_to_oxlint_rule

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Crabcyborg Crabcyborg merged commit e5bfaa1 into master Mar 31, 2026
44 of 46 checks passed
@Crabcyborg Crabcyborg deleted the drop_ref_to_oxlint_rule branch March 31, 2026 15:16
@deepsource-io
Copy link
Copy Markdown

deepsource-io bot commented Mar 31, 2026

DeepSource Code Review

We reviewed changes in e0c1736...fa50f74 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Mar 31, 2026 3:15p.m. Review ↗
JavaScript Mar 31, 2026 3:15p.m. Review ↗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant