Rock: Form Actions Refresh

.windsurf/rules/formidable/frm-css.md

@@ -1,5 +1,5 @@
 ---
-trigger: "glob"
+trigger: glob
 globs: ["**/*.css", "**/*.scss", "**/*.less"]
 description: "WordPress CSS coding standards with Formidable Forms patterns. Auto-applies when working with CSS files."
 ---

classes/controllers/FrmFormActionsController.php

@@ -38,6 +38,7 @@ public static function register_post_types() {
 			)
 		);
 
+		self::maybe_setup_unlicensed_action_gate();
 		self::actions_init();
 	}
 
@@ -56,25 +57,25 @@ public static function register_actions() {
 			'email'             => 'FrmEmailAction',
 			'wppost'            => 'FrmDefPostAction',
 			'register'          => 'FrmDefRegAction',
-			'paypal'            => 'FrmDefPayPalAction',
-			'payment'           => 'FrmTransLiteAction',
 			'quiz'              => 'FrmDefQuizAction',
 			'quiz_outcome'      => 'FrmDefQuizOutcomeAction',
-			'mailchimp'         => 'FrmDefMlcmpAction',
+			'paypal'            => 'FrmDefPayPalAction',
+			'payment'           => 'FrmTransLiteAction',
 			'api'               => 'FrmDefApiAction',
-			'salesforce'        => 'FrmDefSalesforceAction',
+			'mailchimp'         => 'FrmDefMlcmpAction',
 			'activecampaign'    => 'FrmDefActiveCampaignAction',
 			'constantcontact'   => 'FrmDefConstContactAction',
 			'getresponse'       => 'FrmDefGetResponseAction',
-			'hubspot'           => 'FrmDefHubspotAction',
-			'zapier'            => 'FrmDefZapierAction',
-			'n8n'               => 'FrmDefN8NAction',
-			'twilio'            => 'FrmDefTwilioAction',
-			'highrise'          => 'FrmDefHighriseAction',
 			'mailpoet'          => 'FrmDefMailpoetAction',
-			'aweber'            => 'FrmDefAweberAction',
 			'convertkit'        => 'FrmDefConvertKitAction',
+			'aweber'            => 'FrmDefAweberAction',
+			'twilio'            => 'FrmDefTwilioAction',
+			'salesforce'        => 'FrmDefSalesforceAction',
+			'hubspot'           => 'FrmDefHubspotAction',
+			'highrise'          => 'FrmDefHighriseAction',
+			'zapier'            => 'FrmDefZapierAction',
 			'googlespreadsheet' => 'FrmDefGoogleSpreadsheetAction',
+			'n8n'               => 'FrmDefN8NAction',
 		);
 
 		$action_classes = apply_filters( 'frm_registered_form_actions', $action_classes );
@@ -86,6 +87,50 @@ public static function register_actions() {
 		foreach ( $action_classes as $action_class ) {
 			self::$registered_actions->register( $action_class );
 		}
+
+		self::apply_default_action_descriptions();
+	}
+
+	/**
+	 * Sets default descriptions on registered actions from a central list.
+	 *
+	 * Keeps the description when an add-on replaces a base action class without its own.
+	 *
+	 * @since x.x
+	 *
+	 * @return void
+	 */
+	private static function apply_default_action_descriptions() {
+		$descriptions = array(
+			'on_submit'         => __( 'Success messages', 'formidable' ),
+			'email'             => __( 'Autoresponder alerts', 'formidable' ),
+			'wppost'            => __( 'Content publishing', 'formidable' ),
+			'register'          => __( 'Account creation', 'formidable' ),
+			'payment'           => __( 'Transaction alerts', 'formidable' ),
+			'paypal'            => __( 'Payment gateway', 'formidable' ),
+			'quiz'              => __( 'Automated grading', 'formidable' ),
+			'quiz_outcome'      => __( 'Result logic', 'formidable' ),
+			'aweber'            => __( 'List triggers', 'formidable' ),
+			'mailchimp'         => __( 'Subscription confirmation', 'formidable' ),
+			'zapier'            => __( 'App automation', 'formidable' ),
+			'n8n'               => __( 'Workflow automation', 'formidable' ),
+			'twilio'            => __( 'Text notifications', 'formidable' ),
+			'activecampaign'    => __( 'Contact automation', 'formidable' ),
+			'salesforce'        => __( 'Lead automation', 'formidable' ),
+			'constantcontact'   => __( 'Content distribution', 'formidable' ),
+			'getresponse'       => __( 'Success notifications', 'formidable' ),
+			'hubspot'           => __( 'CRM alerts', 'formidable' ),
+			'mailpoet'          => __( 'Plugin automation', 'formidable' ),
+			'api'               => __( 'System integration', 'formidable' ),
+			'googlespreadsheet' => __( 'Spreadsheet sync', 'formidable' ),
+			'convertkit'        => __( 'Broadcast publishing', 'formidable' ),
+		);
+
+		foreach ( self::$registered_actions->actions as $action ) {
+			if ( $action->action_options['description'] === '' && isset( $descriptions[ $action->id_base ] ) ) {
+				$action->action_options['description'] = $descriptions[ $action->id_base ];
+			}
+		}
 	}
 
 	/**
@@ -170,24 +215,27 @@ public static function form_action_groups() {
 				'name'    => '',
 				'icon'    => 'frmfont frm_shuffle_icon',
 				'actions' => array(
+					'on_submit',
 					'email',
 					'wppost',
 					'register',
 					'quiz',
 					'quiz_outcome',
-					'twilio',
+					'api',
+					'googlespreadsheet',
+					'n8n',
 				),
 			),
 			'payment'   => array(
-				'name'    => __( 'eCommerce', 'formidable' ),
+				'name'    => __( 'E-Commerce', 'formidable' ),
 				'icon'    => 'frmfont frm_credit_card_alt_icon',
 				'actions' => array(
 					'paypal',
 					'payment',
 				),
 			),
 			'marketing' => array(
-				'name'    => __( 'Email Marketing', 'formidable' ),
+				'name'    => __( 'Marketing', 'formidable' ),
 				'icon'    => 'frmfont frm_mail_bulk_icon',
 				'actions' => array(
 					'mailchimp',
@@ -197,6 +245,7 @@ public static function form_action_groups() {
 					'aweber',
 					'mailpoet',
 					'convertkit',
+					'twilio',
 				),
 			),
 			'crm'       => array(
@@ -220,6 +269,7 @@ private static function get_crm_actions() {
 		$crm_actions = array(
 			'salesforce',
 			'hubspot',
+			'zapier',
 		);
 
 		// Only include Highrise when the add-on is active.
@@ -300,18 +350,40 @@ public static function show_action_icon_link( $action_control, $allowed ) {
 			if ( $requires && 'free' !== $requires ) {
 				$data['data-requires'] = $requires;
 			}
+
+			$learn_more_slug = ! empty( $action_control->action_options['learn-more'] )
+				? $action_control->action_options['learn-more']
+				: self::get_learn_more_slug( $action_control->id_base );
+
+			if ( $learn_more_slug ) {
+				$data['data-learn-more'] = FrmAppHelper::get_doc_url(
+					$learn_more_slug,
+					'settings-' . $action_control->id_base,
+					str_contains( $learn_more_slug, '/' )
+				);
+			}
 		}//end if
 
-		// HTML to include on the icon.
-		$icon_atts = array();
+		include FrmAppHelper::plugin_path() . '/classes/views/frm-form-actions/_action_icon.php';
+	}
 
-		if ( $action_control->action_options['color'] !== 'var(--primary-700)' ) {
-			$icon_atts = array(
+	/**
+	 * Get the HTML attributes for the action icon.
+	 *
+	 * @since x.x
+	 *
+	 * @param object $action_control
+	 *
+	 * @return array
+	 */
+	public static function get_action_icon_atts( $action_control ) {
+		if ( 'var(--primary-700)' !== $action_control->action_options['color'] ) {
+			return array(
 				'style' => '--primary-700:' . $action_control->action_options['color'],
 			);
 		}
 
-		include FrmAppHelper::plugin_path() . '/classes/views/frm-form-actions/_action_icon.php';
+		return array();
 	}
 
 	/**
@@ -380,6 +452,10 @@ public static function list_actions( $form, $values ) {
 
 		self::maybe_show_limit_warning( $form->id, $form_actions );
 
+		echo '<p class="frm-mb-lg frm-no-actions-message' . ( $form_actions ? ' frm_hidden' : '' ) . '"> '
+		. esc_html__( 'No actions have been added yet. Select an action above to get started.', 'formidable' )
+		. '</p>';
+
 		foreach ( $form_actions as $action ) {
 			if ( ! isset( $action_map[ $action->post_excerpt ] ) ) {
 				// Don't try and show settings if action no longer exists
@@ -448,19 +524,30 @@ public static function add_form_action() {
 		FrmAppHelper::permission_check( 'frm_edit_forms' );
 		check_ajax_referer( 'frm_ajax', 'nonce' );
 
+		$action_type  = FrmAppHelper::get_param( 'type', '', 'post', 'sanitize_text_field' );
+		$lite_actions = array_fill_keys( self::get_lite_actions(), true );
+		if ( ! FrmAppHelper::pro_is_connected() && ! isset( $lite_actions[ $action_type ] ) ) {
+			wp_die();
+		}
+
 		global $frm_vars;
 
-		$action_key  = FrmAppHelper::get_param( 'list_id', '', 'post', 'absint' );
-		$action_type = FrmAppHelper::get_param( 'type', '', 'post', 'sanitize_text_field' );
+		$action_key = FrmAppHelper::get_param( 'list_id', '', 'post', 'absint' );
 
 		/**
 		 * @var FrmFormAction
 		 */
 		$action_control = self::get_form_actions( $action_type );
 		$action_control->_set( $action_key );
 
-		$form_id     = FrmAppHelper::get_param( 'form_id', '', 'post', 'absint' );
-		$form_action = $action_control->prepare_new( $form_id );
+		$form_id         = FrmAppHelper::get_param( 'form_id', '', 'post', 'absint' );
+		$form_action     = $action_control->prepare_new( $form_id );
+		$existing_titles = (array) FrmAppHelper::get_post_param( 'existing_titles', array(), 'sanitize_text_field' );
+
+		if ( $existing_titles ) {
+			$form_action->post_title = self::get_unique_action_title( $form_action->post_title, $existing_titles );
+		}
+
 		$use_logging = self::should_show_log_message( $action_type );
 		$values      = array();
 		$form        = self::fields_to_values( $form_id, $values );
@@ -469,6 +556,27 @@ public static function add_form_action() {
 		wp_die();
 	}
 
+	/**
+	 * Returns the first available title not in $existing_titles, appending " (2)", " (3)", etc. if needed.
+	 *
+	 * @since x.x
+	 *
+	 * @param string   $base_title      Default action title from the action type.
+	 * @param string[] $existing_titles Titles currently visible in the form editor.
+	 *
+	 * @return string
+	 */
+	private static function get_unique_action_title( $base_title, array $existing_titles ) {
+		$taken = array_flip( $existing_titles );
+		$title = $base_title;
+
+		for ( $n = 2; isset( $taken[ $title ] ); $n++ ) {
+			$title = $base_title . ' (' . $n . ')';
+		}
+
+		return $title;
+	}
+
 	public static function fill_action() {
 		FrmAppHelper::permission_check( 'frm_edit_forms' );
 		check_ajax_referer( 'frm_ajax', 'nonce' );
@@ -801,6 +909,115 @@ public static function limit_by_type( $where ) {
 	public static function prevent_wpml_translations( $null, $post_type ) {
 		return self::$action_post_type === $post_type ? false : $null;
 	}
+
+	/**
+	 * If Pro is not connected, hook a filter that will force all non-Lite
+	 * actions to inactive so the upgrade popup is shown instead.
+	 *
+	 * @since x.x
+	 *
+	 * @return void
+	 */
+	private static function maybe_setup_unlicensed_action_gate() {
+		if ( FrmAppHelper::pro_is_connected() ) {
+			return;
+		}
+
+		add_filter( 'frm_registered_form_actions', array( __CLASS__, 'disable_unlicensed_actions' ), 100 );
+	}
+
+	/**
+	 * For every registered action that is not a Lite action, add a per-action
+	 * options filter that forces it to inactive with the upgrade class.
+	 *
+	 * Runs inside apply_filters('frm_registered_form_actions') at priority 100,
+	 * so the per-key option filters are in place before the class constructors
+	 * run in the foreach loop that follows.
+	 *
+	 * @since x.x
+	 *
+	 * @param array $actions Map of action_key => class_name.
+	 *
+	 * @return array
+	 */
+	public static function disable_unlicensed_actions( $actions ) {
+		$lite_actions = array_fill_keys( self::get_lite_actions(), true );
+
+		foreach ( array_keys( $actions ) as $key ) {
+			if ( isset( $lite_actions[ $key ] ) ) {
+				continue;
+			}
+
+			add_filter(
+				'frm_' . $key . '_action_options',
+				function ( $options ) {
+					$options['active'] = false;
+					if ( ! str_contains( $options['classes'], 'frm_show_upgrade' ) ) {
+						$options['classes'] .= ' frm_show_upgrade';
+					}
+					return $options;
+				}
+			);
+		}//end foreach
+
+		return $actions;
+	}
+
+	/**
+	 * Get action keys that are available in Lite without a Pro license.
+	 *
+	 * @since x.x
+	 *
+	 * @return string[]
+	 */
+	public static function get_lite_actions() {
+		return apply_filters( 'frm_lite_form_actions', array( 'on_submit', 'email', 'payment' ) );
+	}
+
+	/**
+	 * Single source of truth for learn-more doc slugs used in
+	 * upgrade modals for non-Lite form actions.
+	 *
+	 * @since x.x
+	 *
+	 * @return array<string,string> Map of action_key => doc slug.
+	 */
+	public static function get_action_learn_more_links() {
+		return array(
+			'wppost'            => 'using-add-form-actions#kb-create-a-post',
+			'register'          => 'user-registration',
+			'paypal'            => 'formidable-paypal',
+			'quiz'              => 'quiz-maker-forms',
+			'quiz_outcome'      => 'quiz-maker-forms',
+			'aweber'            => 'formidable-aweber',
+			'mailchimp'         => 'formidable-mailchimp',
+			'zapier'            => 'formidable-zapier',
+			'twilio'            => 'twilio-add-on',
+			'activecampaign'    => 'activecampaign-forms',
+			'salesforce'        => 'salesforce-forms',
+			'constantcontact'   => 'constant-contact-forms',
+			'getresponse'       => 'getresponse-forms',
+			'hubspot'           => 'hubspot-forms',
+			'mailpoet'          => 'mailpoet-newsletter-signup-forms',
+			'api'               => 'formidable-api',
+			'googlespreadsheet' => 'google-spreadsheet-forms',
+			'n8n'               => 'n8n',
+			'convertkit'        => 'convertkit-forms',
+		);
+	}
+
+	/**
+	 * Look up the learn-more doc slug for a given action key.
+	 *
+	 * @since x.x
+	 *
+	 * @param string $action_key Action identifier (e.g. 'register').
+	 * @return string Doc slug or empty string.
+	 */
+	private static function get_learn_more_slug( $action_key ) {
+		$links = self::get_action_learn_more_links();
+		return isset( $links[ $action_key ] ) ? $links[ $action_key ] : '';
+	}
 }
 
 class Frm_Form_Action_Factory {