Skip to content

Update the list of Form Actions that support logging messages#2919

Open
AbdiTolesa wants to merge 4 commits intomasterfrom
issue-6292
Open

Update the list of Form Actions that support logging messages#2919
AbdiTolesa wants to merge 4 commits intomasterfrom
issue-6292

Conversation

@AbdiTolesa
Copy link
Copy Markdown
Contributor

@AbdiTolesa AbdiTolesa commented Feb 3, 2026

Fix https://github.com/Strategy11/formidable-pro/issues/6292

Summary by CodeRabbit

  • Bug Fixes
    • Expanded logging coverage to include many additional third‑party integration providers (email, CRM, automation and messaging services), improving activity tracking and monitoring across more integrations.
    • No other user-facing behavior changes beyond broader log visibility.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

The should_show_log_message function in FrmFormActionsController was updated to expand its logging whitelist array to include many additional provider action types while preserving the original return logic.

Changes

Cohort / File(s) Summary
Logging Whitelist Expansion
classes/controllers/FrmFormActionsController.php
Expanded the $logging whitelist in should_show_log_message to add multiple integration providers (e.g., aweber, campaignmonitor, convertkit, getresponse, googlespreadsheet, hubspot, mailchimp, mailpoet, n8n, twilio, zapier, etc.), retaining the same presence-check and frm_log_autoloader condition.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through lines of code today,
I added friends to logging's play,
Aweber, Zapier, Mail, and more,
Now action traces show on store,
A tiny hop — the logs hooray! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the list of Form Actions that support logging messages, which matches the core modification in the should_show_log_message function.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch issue-6292

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@deepsource-io
Copy link
Copy Markdown

deepsource-io bot commented Feb 3, 2026

Here's the code health analysis summary for commits 8f7ba69..07b87bd. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource PHP LogoPHP✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@AbdiTolesa AbdiTolesa self-assigned this Feb 3, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@classes/controllers/FrmFormActionsController.php`:
- Around line 504-507: The should_show_log_message function omits 'convertkit'
from the $logging list even though convertkit is registered elsewhere; confirm
whether that exclusion is intentional (e.g., premium/upgrade behavior handled in
the exclusion code path) and then either add 'convertkit' to the $logging array
in should_show_log_message to enable logging for that integration or, if
exclusion is deliberate, add a brief comment in should_show_log_message
referencing the exclusion reason and where convertkit is handled (the convertkit
registration/exclusion code) so future readers understand why it's absent;
ensure you update the $logging array within should_show_log_message (or the
comment) accordingly and keep campaignmonitor behavior unchanged.

@AbdiTolesa AbdiTolesa requested a review from Crabcyborg February 3, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant