Update the list of Form Actions that support logging messages#2919
Update the list of Form Actions that support logging messages#2919AbdiTolesa wants to merge 4 commits intomasterfrom
Conversation
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@classes/controllers/FrmFormActionsController.php`:
- Around line 504-507: The should_show_log_message function omits 'convertkit'
from the $logging list even though convertkit is registered elsewhere; confirm
whether that exclusion is intentional (e.g., premium/upgrade behavior handled in
the exclusion code path) and then either add 'convertkit' to the $logging array
in should_show_log_message to enable logging for that integration or, if
exclusion is deliberate, add a brief comment in should_show_log_message
referencing the exclusion reason and where convertkit is handled (the convertkit
registration/exclusion code) so future readers understand why it's absent;
ensure you update the $logging array within should_show_log_message (or the
comment) accordingly and keep campaignmonitor behavior unchanged.
Fix https://github.com/Strategy11/formidable-pro/issues/6292
Summary by CodeRabbit