Reposition frm_extra_form_instructions_hook

[AbdiTolesa]

Related ticket: https://secure.helpscout.net/conversation/3174611369/244321

[coderabbitai]

Walkthrough

A single action hook (frm_extra_form_instructions) was relocated within the form view file from its original position inside the first panel to a later position after the field sections, changing where it executes in the DOM hierarchy.

Changes

Cohort / File(s)	Summary
Action Hook Relocation classes/views/frm-forms/add_field_links.php	Moved frm_extra_form_instructions action hook execution from inside the initial panel to a position following field sections, altering the DOM rendering order.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the main change: repositioning the frm_extra_form_instructions hook, which matches the summary of moving the action hook to a different location in the file.
Description check	✅ Passed	The description references a related support ticket, demonstrating awareness of context, though it provides minimal detail about the actual changes made.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch reposition_frm_extra_form_instructions_hook

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa9deb2 and 77ed114.

📒 Files selected for processing (1)

• classes/views/frm-forms/add_field_links.php

🔇 Additional comments (1)

classes/views/frm-forms/add_field_links.php (1)

200-200: No internal code depends on this hook; external impact cannot be verified through codebase search.

The frm_extra_form_instructions hook has no internal usages (add_action calls) within the repository and exists only as a trigger point at line 200. This repositioning will not cause internal breakage. However, any potential impact on external extensions or add-ons that consume this hook remains unverifiable through repository analysis alone, as their code is not available here. If known extensions depend on this hook's specific DOM position, test with them to ensure continued functionality.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Crabcyborg]

@AbdiTolesa I think this is too risky. I left a comment in Helpscout about how this is a breaking change https://secure.helpscout.net/conversation/3174611369/244321#thread-9700394418

I think we could add a new hook instead, and consider deprecating the old hook.

Let's leave deprecating for now though. I don't know if it's really worth trying to remove this one.

[AbdiTolesa]

I think we could add a new hook instead, and consider deprecating the old hook.

@Crabcyborg I just created another PR with a more descriptive name: #2952

Closing this in favor of the new approach.