Closed
Conversation
Member
Author
|
Changing implementation to make it so it applies the key using Also disabling my auto formatter |
bc84c41 to
06ebd1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API | Impl
Original Issue:
Calling the following code would cause a
ClassCastExceptioncaused byRecipenot being able to be cast toRecipeHolder.The issue is that in MC 1.21.1, recipes added a wrapper that holds the recipe and the associated key in
RecipeHolderand the internalRecipeManagernow outputs thoseRecipeHolderrather thenRecipe.