Draft
Conversation
aromaa
added
api: pending
6 tasks
Zidane
reviewed
Apr 23, 2024
| @Override | ||
| public PerspectiveContainer<?, ?> createDataPerception(final DataPerspective perspective) { | ||
| return this.perspectives.computeIfAbsent(perspective, p -> { | ||
| if (p instanceof final Entity entity) { |
Member
There was a problem hiding this comment.
Maybe add a bridge to all the perspectives implement that returns the container? Feels cleaner than this if chain that may keep growing over time.
Member
Author
There was a problem hiding this comment.
Could be done but it can also be super confusing because the PerspectiveContainer have different behavior depending on is the entity itself the holder as in ContextualDataHolder or some other type like Team which uses ContextualDataDelegate that propagates the updates differently.
The difference is in the implementation of PerspectiveContainer#offer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sponge | SpongeAPI
Implemented data directions:
Implemented data operations: