Skip to content

feat: add Crimson White theme#356

Merged
Splode merged 1 commit intoSplode:mainfrom
Hungerdream:feat/add-crimson-white-theme
Mar 18, 2026
Merged

feat: add Crimson White theme#356
Splode merged 1 commit intoSplode:mainfrom
Hungerdream:feat/add-crimson-white-theme

Conversation

@Hungerdream
Copy link
Contributor

A clean white background theme with red accent colors, inspired by the tomato color palette of Pomodoro.

  • Focus round: deep crimson red (#c0392b)

  • Short break: soft rose (#f28b82)

  • Long break: warm red (#e05252)

  • Background: pure white with light gray layers

  • Accent: dark red (#a31515)

  • Added static/themes/crimson-white.json

  • Registered theme in src-tauri/src/themes/mod.rs

  • Updated bundled theme count assertion (37 → 38)

  • Added dedicated test crimson_white_theme_is_bundled

Copy link
Owner

@Splode Splode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The theme itself looks great — all required color keys are present and the palette is clean.

One request before merging: the mod.rs diff includes a number of unrelated changes — removed section comment banners, removed inline doc comments, and several multi-line blocks reformatted onto single lines. These make the diff harder to review and mix unrelated cleanup into a theme PR.

Could you revert src-tauri/src/themes/mod.rs to its original formatting, keeping only the three changes needed to add the theme?

  1. The include_str!("../../../static/themes/crimson-white.json") line in BUNDLED_JSON
  2. The count assertion bumped from 37 to 38
  3. The new crimson_white_theme_is_bundled test

The theme file itself is ready to go — just needs the tidy-up on mod.rs.

- Add crimson-white.json theme file
- Register theme in mod.rs with include_str!
- Update test count from 37 to 38
- Add crimson_white_theme_is_bundled test
@Hungerdream Hungerdream force-pushed the feat/add-crimson-white-theme branch from 1e5463d to 3aaa8f5 Compare March 18, 2026 00:32
@Hungerdream
Copy link
Contributor Author

Hi @Splode, I've updated the PR as requested. The mod.rs now contains only the 3 minimal changes needed to add the Crimson White theme. Ready for review!

@Splode
Copy link
Owner

Splode commented Mar 18, 2026

@Hungerdream Looks good, thank you!

@Splode Splode merged commit 6a9ce65 into Splode:main Mar 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants