Skip to content

Fix order of units in mergeview #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alejoe91 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix order of units in mergeview #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spikeinterface_gui/mergeview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def _qt_make_layout(self):

def _qt_refresh(self):
from .myqt import QT
from .utils_qt import CustomItem
from .utils_qt import CustomItem, CustomItemMergeUnitID

self.table.clear()
self.table.setSortingEnabled(False)
Expand Down Expand Up @@ -298,7 +298,7 @@ def _qt_refresh(self):
pix = QT.QPixmap(16, 16)
pix.fill(color)
icon = QT.QIcon(pix)
item = QT.QTableWidgetItem(name)
item = CustomItemMergeUnitID(name)
item.setData(QT.Qt.ItemDataRole.UserRole, unit_id)
item.setFlags(QT.Qt.ItemIsEnabled | QT.Qt.ItemIsSelectable)
self.table.setItem(r, c, item)
Expand Down
12 changes: 12 additions & 0 deletions spikeinterface_gui/utils_qt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,18 @@ def __lt__(self, other):
other_ind = self.unit_ids.index(other.text())
return ind < other_ind

class CustomItemMergeUnitID(QT.QTableWidgetItem):
# special case for merge view unit_id columns: sort numerically by the unit_id stored in UserRole
def __lt__(self, other):
self_data = self.data(QT.Qt.ItemDataRole.UserRole)
other_data = other.data(QT.Qt.ItemDataRole.UserRole)
if self_data is not None and other_data is not None:
try:
return float(self_data) < float(other_data)
except (TypeError, ValueError):
pass
return self.text() < other.text()

class OrderableCheckItem(QT.QTableWidgetItem):
# special case for checkbox
def is_checked(self):
Expand Down