Skip to content

fix: AntiXssLibrary missing dependency BED-7686 #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lrfalslev merged 1 commit into from
Mar 18, 2026
+9 −3
Merged

fix: AntiXssLibrary missing dependency BED-7686 #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RPCTest/RPCTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
<LangVersion>latest</LangVersion>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<!-- Suppress cross-targeting warning when referencing net472 projects in net8.0 tests -->
<NoWarn>$(NoWarn);NU1702</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/CommonLib/SharpHoundCommonLib.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<DebugType>full</DebugType>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="AntiXSS" Version="4.3.0" PrivateAssets="All"/>
<PackageReference Include="AntiXSS" Version="4.3.0" />
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
</ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions test/unit/CommonLibTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
<CollectCoverage>true</CollectCoverage>
<CoverletOutput>..\..\docfx\coverage\</CoverletOutput>
<CoverletOutputFormat>OpenCover</CoverletOutputFormat>
<!-- Suppress cross-targeting warning when referencing net472 SharpHound projects in net8.0 tests -->
<NoWarn>$(NoWarn);NU1702</NoWarn>
<!-- Suppress cross-targeting warning when referencing net472 projects/packages in net8.0 tests -->
<NoWarn>$(NoWarn);NU1702;NU1701</NoWarn>
</PropertyGroup>

<!-- Project references -->
Expand Down
4 changes: 4 additions & 0 deletions test/unit/RegistryProcessorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Runtime.Versioning;
using System.Threading.Tasks;
using CommonLibTest.Facades;
using Microsoft.Extensions.Logging;
Expand Down Expand Up @@ -74,6 +75,7 @@ public async Task RegistryProcessor_ReadRegistrySettings_CollectionFailed() {
}
}

[SupportedOSPlatform("windows")]
[WindowsOnlyFact]
public async Task RegistryProcessor_ReadRegistrySettings_FirstStrategySuccessful() {
const uint minClientSecValue = 536870912;
Expand Down Expand Up @@ -106,6 +108,7 @@ public async Task RegistryProcessor_ReadRegistrySettings_FirstStrategySuccessful
VerifyCompStatusLog(task, TargetName, CSVComputerStatus.StatusSuccess);
}

[SupportedOSPlatform("windows")]
[WindowsOnlyFact]
public async Task RegistryProcessor_ReadRegistrySettings_SecondStrategySuccessful() {
const string failureReason = "No such host is known.";
Expand Down Expand Up @@ -166,6 +169,7 @@ public async Task RegistryProcessor_ReadRegistrySettings_HandlesException() {
Assert.Empty(_receivedCompStatuses);
}

[SupportedOSPlatform("windows")]
[WindowsOnlyFact]
public async Task RegistryProcessor_ReadRegistrySettings_SetsAllValues() {
var allowedServers = new[] {"server"};
Expand Down
Loading