Conversation
…ance-based classes under CNCMachine Co-authored-by: nsiatras <6023918+nsiatras@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor managers to be public static references in CNCMachine
Refactor BacklashManager, MotorsManager, CoolantManager, Probe into CNCMachine singleton
Feb 24, 2026
Co-authored-by: nsiatras <6023918+nsiatras@users.noreply.github.com>
Co-authored-by: nsiatras <6023918+nsiatras@users.noreply.github.com>
Copilot
AI
changed the title
Refactor BacklashManager, MotorsManager, CoolantManager, Probe into CNCMachine singleton
Fix circular include error in CNCMachine.h
Feb 24, 2026
Copilot
AI
changed the title
Fix circular include error in CNCMachine.h
Fix circular include between CNCMachine.h and manager headers
Feb 24, 2026
Co-authored-by: nsiatras <6023918+nsiatras@users.noreply.github.com>
Copilot
AI
changed the title
Fix circular include between CNCMachine.h and manager headers
Add CNCMachine::Initialize() and CNCMachine::Reset() static methods
Feb 24, 2026
Copilot
AI
changed the title
Add CNCMachine::Initialize() and CNCMachine::Reset() static methods
Refactor BacklashManager, MotorsManager, CoolantManager, Probe into instance-based classes under CNCMachine
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four all-static utility classes (
BacklashManager,MotorsManager,CoolantManager,Probe) have been converted to regular instantiable classes, with their single instances owned aspublic staticmembers of a newCNCMachineclass. This centralises machine subsystem access and lifecycle management.Class changes
staticfrom all methods and member variables inBacklashManager,MotorsManager,CoolantManager, andProbe.cppfilesNew
CNCMachineclass (CNCMachine.h/CNCMachine.cpp)public staticmembersstatic void Initialize()andstatic void Reset()lifecycle methodsCall-site updates
All direct calls replaced with the new access pattern across
Grbl.cpp,MotionControl.cpp,GCode.cpp,Stepper.cpp,ProcessSettings.cpp,Limits.cpp,Report.cpp,Protocol.cpp:Include structure
CNCMachine.hdeliberately does not re-include the manager headers — doing so created a circular chain (BacklashManager.h → Grbl.h → CNCMachine.h → BacklashManager.h).Grbl.hincludes all four manager headers beforeCNCMachine.h, ensuring types are defined when needed.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.