SCANPY-214: Change property name --sonar-cpd-python-minimum-tokens to --sonar-cpd-py-minimum-tokens#248
SCANPY-214: Change property name --sonar-cpd-python-minimum-tokens to --sonar-cpd-py-minimum-tokens#248
Conversation
… --sonar-cpd-py-minimum-tokens
Seppli11
left a comment
There was a problem hiding this comment.
The change itself looks good. However, this would be a breaking change.
As such, I think it would make sense to keep both --sonar-cpd-py-minimum-lines and --sonar-cpd-python-minimum-lines (the same applies for the minimum tokens).
This would still be a breaking change for the environment variable parsing, but I feel like we could live with that
| "--sonar-cpd-py-minimum-lines", | ||
| "-Dsonar.cpd.py.minimumLines", | ||
| "--sonar-cpd-python-minimum-lines", | ||
| "-Dsonar.cpd.python.minimumLines", |
There was a problem hiding this comment.
The -Dsonar.cpd.python.minimumLines we shouldn't need, since any non-consumed parameter beginning with -D... will be passed along.
Same applies for minimum tokens.
There was a problem hiding this comment.
I think we should keep them as we will pass the property to the correct sonar.cpd.py....
There was a problem hiding this comment.
True. I think the PR can be merged then
|




SCANPY-214
Part of