Draft
Conversation
…nto kmonte/gigl-base-loader
Collaborator
Author
|
/integration_test |
Collaborator
Author
|
/unit_test_py |
Contributor
GiGL Automation@ 24:06:52UTC : 🔄 @ 01:31:11UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 24:06:53UTC : 🔄 @ 01:31:44UTC : ✅ Workflow completed successfully. |
Collaborator
Author
|
/unit_test_py |
Collaborator
Author
|
/integration_test |
Contributor
GiGL Automation@ 24:18:19UTC : 🔄 @ 01:43:28UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 24:18:25UTC : 🔄 @ 01:30:18UTC : ✅ Workflow completed successfully. |
Collaborator
Author
|
/e2e_test |
Contributor
GiGL Automation@ 24:19:50UTC : 🔄 @ 01:49:57UTC : ✅ Workflow completed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
There's a lot of code duplication going on between the two loaders, we should consolidate so that we can more easily expand / make changes in the future.
I'm choosing to still subclass the GLT loader - I synced with @mkolodner-sc about this offline and I think we wanted to copy over whole-sale but IMO it's a "better" design to not copy over what we don't need to - and we can always update in the future to take all of the code we need.
The key thing we're enabling here is passing in
samplerso that we can have the sampler (e.g. ablp sampler, ppr sampler, etc) delegated to the children classes.Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO