Matter Sensor: fix gating for modular profile update#2766
Open
nickolas-deboom wants to merge 1 commit intomainfrom
Open
Matter Sensor: fix gating for modular profile update#2766nickolas-deboom wants to merge 1 commit intomainfrom
nickolas-deboom wants to merge 1 commit intomainfrom
Conversation
The `MODULAR_PROFILE_UPDATED` flag check in infoChanged could cause a subscription request to be sent out before the actual profile update takes place if the infoChanged event was caused by something other than a profile update. This change adds a function to check if the profile was actually updated before sending the subscription request.
|
Invitation URL: |
Test Results 71 files 485 suites 0s ⏱️ Results for commit 667c9cd. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 667c9cd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@hcarter-775 discovered that the
MODULAR_PROFILE_UPDATEDflag check in infoChanged could cause a subscription request to be sent out before the actual profile update takes place if the infoChanged event was caused by something other than a profile update. This change adds a function to check if the profile was actually updated before sending the subscription request.