Skip to content

Postpone updating commandResult#2765

Open
HunsupJung wants to merge 1 commit intomainfrom
fix/postpone-updating-commandResult
Open

Postpone updating commandResult#2765
HunsupJung wants to merge 1 commit intomainfrom
fix/postpone-updating-commandResult

Conversation

@HunsupJung
Copy link
Collaborator

@HunsupJung HunsupJung commented Feb 6, 2026

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

After the creation of the Guest is completed, Plugin calls the updateUser command is immediately to update the name information of the Guest. That point is after receiving the commandResult of lockCredentail.
Since the default schedule is updated when creating a Guest User in the driver, if the commandResult is updated before the default schedule is updated in the driver, it will be in busy state unconditionally when the updateUser command is called in the Plugin
Therefore, when creating a Guest User, update the commandResult after the schedule input is completed.

Summary of Completed Tests

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Test Results

   71 files    485 suites   0s ⏱️
2 518 tests 2 518 ✅ 0 💤 0 ❌
4 332 runs  4 332 ✅ 0 💤 0 ❌

Results for commit 46ad631.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

File Coverage
All files 72%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 65%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 46ad631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant