Open
Conversation
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
|
Invitation URL: |
Test Results 71 files 485 suites 0s ⏱️ For more details on these failures, see this check. Results for commit 120f200. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 120f200 |
hcarter-775
reviewed
Feb 6, 2026
Comment on lines
+1277
to
+1280
| local userNameMatter = userName | ||
| if #userNameMatter > NAME_MAX_L then | ||
| userNameMatter = string.sub(userNameMatter, 1, NAME_MAX_L) | ||
| end |
Contributor
There was a problem hiding this comment.
Suggested change
| local userNameMatter = userName | |
| if #userNameMatter > NAME_MAX_L then | |
| userNameMatter = string.sub(userNameMatter, 1, NAME_MAX_L) | |
| end | |
| local userName = string.sub(command.args.userName, 1, NAME_MAX_L) |
the sub will only limit the userName input if it is too long, so no need for the extra check, or the extra variable
hcarter-775
reviewed
Feb 6, 2026
|
|
||
| local INITIAL_CREDENTIAL_INDEX = 1 | ||
| local ALL_INDEX = 0xFFFE | ||
| local NAME_MAX_L = 10 |
Contributor
There was a problem hiding this comment.
Suggested change
| local NAME_MAX_L = 10 | |
| -- maximum as defined by the Matter specification | |
| local MAX_USER_NAME_LENGTH = 10 |
hcarter-775
reviewed
Feb 6, 2026
| if userIdx == 0 then | ||
| userIdx = nil | ||
| else | ||
| userTypeMatter = nil |
Contributor
There was a problem hiding this comment.
curious, why should this be nil if userIdx > 0?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
Summary of Completed Tests