Matter Thermostat: Add 'off' to thermostatMode by default only if switch is not supported#2761
Open
hcarter-775 wants to merge 1 commit intomainfrom
Open
Matter Thermostat: Add 'off' to thermostatMode by default only if switch is not supported#2761hcarter-775 wants to merge 1 commit intomainfrom
hcarter-775 wants to merge 1 commit intomainfrom
Conversation
hcarter-775
requested review from
ctowns,
greens,
nickolas-deboom and
tpmanley
|
Invitation URL: |
Test Results 71 files 485 suites 0s ⏱️ Results for commit 0e2b5c9. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 0e2b5c9 |
drivers/SmartThings/matter-thermostat/src/thermostat_handlers/attribute_handlers.lua
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Insert gating to only add the optional "off" mode to thermostatMode in the case that the switch capability is not supported, since this can implement the same behavior more naturally.
Summary of Completed Tests