WWSTCERT-10225/10228/10231/10234 add driver to frient EMI devices by marcintyminski · Pull Request #2730 · SmartThingsCommunity/SmartThingsEdgeDrivers

marcintyminski · 2026-01-26T13:28:33Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

github-actions · 2026-01-26T13:29:00Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2026-01-26T13:29:43Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/r3Mykko5JlpR

github-actions · 2026-01-26T13:30:26Z

Test Results

71 files 488 suites 0s ⏱️
2 523 tests 2 523 ✅ 0 💤 0 ❌
4 349 runs 4 349 ✅ 0 💤 0 ❌

Results for commit 9b2dc97.

♻️ This comment has been updated with latest results.

github-actions · 2026-01-26T13:30:28Z

File	Coverage
All files	`94%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/frient/init.lua	`93%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/shinasystems/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/init.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/configurations.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/lazy_load_subdriver.lua	`57%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua	`91%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/bituo/init.lua	`95%`	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 9b2dc97

greens · 2026-02-05T19:53:40Z

drivers/SmartThings/zigbee-power-meter/profiles/power-energy-battery-consumption-report.yml

+  - title: "Pulse Configuration"
+    name: pulseConfiguration
+    description: "Number of pulses the meter outputs per unit"
+    required: false
+    preferenceType: integer
+    definition:
+      minimum: 50
+      maximum: 10000
+      default: 1000


What does this mean?

Pulse Configuration is the number of pulses the meter outputs per unit. It may be different depending on the meter, so we need an option to adjust it, so that the device reads measurements properly from a wide range of meters.

greens · 2026-02-05T19:55:14Z

drivers/SmartThings/zigbee-power-meter/profiles/power-energy-current-voltage.yml

All of these profiles should have different names, I think.

The first two are going to be frient-specific because of the preferences, and the third has a misleading name since it uses components.

greens · 2026-02-05T19:55:20Z

drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/can_handle.lua

@@ -0,0 +1,15 @@
+-- Copyright 2025 SmartThings, Inc.


pegor-karoglanian · 2026-02-05T19:53:12Z

drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua

+    attribute = SimpleMetering.attributes.CurrentSummationDelivered.ID,
+    minimum_interval = 5,
+    maximum_interval = 3600,
+    data_type = data_types.Uint48,


Does this and the above need to be Uint48?

pegor-karoglanian · 2026-02-05T19:53:19Z

drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua

@@ -0,0 +1,362 @@
+-- Copyright 2025 SmartThings, Inc.


pegor-karoglanian · 2026-02-05T19:53:23Z

drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/fingerprints.lua

@@ -0,0 +1,8 @@
+-- Copyright 2025 SmartThings, Inc.


pegor-karoglanian · 2026-02-05T19:53:28Z

drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/can_handle.lua

@@ -0,0 +1,15 @@
+-- Copyright 2025 SmartThings, Inc.


pegor-karoglanian · 2026-02-05T19:56:48Z

drivers/SmartThings/zigbee-power-meter/src/frient/init.lua

+    }
+  },
+  sub_drivers = {
+    require("frient/EMIZB-151")


match formatting -> frient.EMIZB-151

pegor-karoglanian · 2026-02-05T19:57:00Z

...rtThings/zigbee-power-meter/src/test/test_frient_power_energy_battery_consumption_report.lua

@@ -0,0 +1,340 @@
+-- Copyright 2025 SmartThings


pegor-karoglanian · 2026-02-05T19:57:14Z

drivers/SmartThings/zigbee-power-meter/src/test/test_frient_power_energy_consumption_report.lua

@@ -0,0 +1,303 @@
+-- Copyright 2025 SmartThings


pegor-karoglanian · 2026-02-05T19:57:27Z

drivers/SmartThings/zigbee-power-meter/src/test/test_frient_power_energy_current_voltage.lua

@@ -0,0 +1,396 @@
+-- Copyright 2025 SmartThings


pegor-karoglanian · 2026-02-05T19:58:24Z

drivers/SmartThings/zigbee-power-meter/src/sub_drivers.lua

   lazy_load_if_possible("frient"),
   lazy_load_if_possible("shinasystems"),
   lazy_load_if_possible("bituo"),
+   lazy_load_if_possible("frient/EMIZB-151")


If I'm not mistake, I think this should live as a subdriver within the frient init. Thoughts @greens ?

pegor-karoglanian · 2026-02-05T19:59:03Z

drivers/SmartThings/zigbee-power-meter/fingerprints.yml

+    deviceProfileName: power-energy-consumption-report
+  - id: "frient A/S/EMIZB-132"
    deviceLabel: frient Energy Monitor
-    manufacturer: Develco Products A/S


Are these no longer necessary?

greens · 2026-02-05T20:01:33Z

drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua

+  raw_value = raw_value * multiplier / divisor * 1000
+
+  -- The result is already in watts, no need to multiply by 1000
+  device:emit_component_event(device.profile.components['main'], capabilities.powerMeter.power({ value = raw_value, unit = "W" }))


when emitting for the main component, you can just use device:emit_event

Also this seems identical to the defaults except for the default value, which you could set elsewhere (like in added) with

device:set_field(zigbee_constants.SIMPLE_METERING_DIVISOR_KEY, SIMPLE_METERING_DEFAULT_DIVISOR)

instead of overriding the default behavior

greens · 2026-02-05T20:03:04Z

drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua

+  device:send(ElectricalMeasurement.attributes.ACPowerDivisor:read(device))
+  device:send(ElectricalMeasurement.attributes.ACPowerMultiplier:read(device))
+  device:send(ElectricalMeasurement.attributes.ACVoltageMultiplier:read(device))
+  device:send(ElectricalMeasurement.attributes.ACVoltageDivisor:read(device))
+  device:send(ElectricalMeasurement.attributes.ACCurrentMultiplier:read(device))
+  device:send(ElectricalMeasurement.attributes.ACCurrentDivisor:read(device))


I would expect these should be sent already by device:refresh() since they're configured attributes.

greens · 2026-02-05T20:04:29Z

drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua

+  if divisor == 0 then
+    divisor = 1
+  end


Instead of checking for 0 every time here, you could just make sure that when you set a divisor, you just throw out the value if it's 0.

greens · 2026-02-05T20:06:47Z

drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua

+local active_power_handler = function(component)
+  local handler = function(driver, device, value, zb_rx)
+    local raw_value = value.value
+    -- By default emit raw value
+    local multiplier = device:get_field(zigbee_constants.ELECTRICAL_MEASUREMENT_MULTIPLIER_KEY) or 1
+    local divisor = device:get_field(zigbee_constants.ELECTRICAL_MEASUREMENT_DIVISOR_KEY) or 1
+
+    if divisor == 0 then
+      divisor = 1
+    end
+
+    raw_value = raw_value * multiplier / divisor
+
+    device:emit_component_event(device.profile.components[component], capabilities.powerMeter.power({ value = raw_value, unit = "W" }))
+  end
+
+  return handler
+end
+
+local rms_voltage_handler = function(component)
+  local handler = function(driver, device, value, zb_rx)
+    local raw_value = value.value
+    -- By default emit raw value
+    local multiplier = device:get_field(zigbee_constants.ELECTRICAL_MEASUREMENT_AC_VOLTAGE_MULTIPLIER_KEY) or 1
+    local divisor = device:get_field(zigbee_constants.ELECTRICAL_MEASUREMENT_AC_VOLTAGE_DIVISOR_KEY) or 1
+
+    if divisor == 0 then
+      divisor = 1
+    end
+
+    raw_value = raw_value * multiplier / divisor
+
+    device:emit_component_event(device.profile.components[component], capabilities.voltageMeasurement.voltage({ value = raw_value, unit = "V" }))
+  end
+
+  return handler
+end
+
+local rms_current_handler = function(component)
+  local handler = function(driver, device, value, zb_rx)
+    local raw_value = value.value
+    -- By default emit raw value
+    local multiplier = device:get_field(zigbee_constants.ELECTRICAL_MEASUREMENT_AC_CURRENT_MULTIPLIER_KEY) or 1
+    local divisor = device:get_field(zigbee_constants.ELECTRICAL_MEASUREMENT_AC_CURRENT_DIVISOR_KEY) or 1
+
+    if divisor == 0 then
+      divisor = 1
+    end
+
+    raw_value = raw_value * multiplier / divisor
+
+    device:emit_component_event(device.profile.components[component], capabilities.currentMeasurement.current({ value = raw_value, unit = "A" }))
+  end
+
+  return handler
+end


these three could be consolidated further by having the mul/div keys, unit, and the attribute as arguments as well

greens · 2026-02-05T20:11:02Z

drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua

+    raw_value = 1
+  end
+
+  device:set_field(zigbee_constants.SIMPLE_METERING_DIVISOR_KEY, raw_value, { persist = true })


I'm not seeing a lot of added value over the default handling here.

Is the device often sending these updates with the mfg-specific bit set? It shouldn't be, since this is a standard attribute.

greens · 2026-02-05T20:14:22Z

drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua

+  {
+    cluster = SimpleMetering.ID,
+    attribute = SimpleMetering.attributes.InstantaneousDemand.ID,
+    minimum_interval = 5,
+    maximum_interval = 3600,
+    data_type = data_types.Int24,
+    reportable_change = 1
+  },


same as the default

default reportable_change is 5. We want it to be as sensitive as possible

greens · 2026-02-05T20:14:45Z

drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua

+  {
+    cluster = ElectricalMeasurement.ID,
+    attribute = ElectricalMeasurement.attributes.ActivePower.ID,
+    minimum_interval = 5,
+    maximum_interval = 3600,
+    data_type = data_types.Int16,
+    reportable_change = 5
+  },


same as the default

greens · 2026-02-05T20:15:39Z

drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua

+  {
+    cluster = SimpleMetering.ID,
+    attribute = SimpleMetering.attributes.CurrentSummationDelivered.ID,
+    minimum_interval = 5,
+    maximum_interval = 3600,
+    data_type = data_types.Uint48,
+    reportable_change = 1
+  },


same as the defaults

greens · 2026-02-05T20:16:16Z

drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua

+zigbee_constants.ELECTRICAL_MEASUREMENT_AC_VOLTAGE_MULTIPLIER_KEY = "_electrical_measurement_ac_voltage_multiplier"
+zigbee_constants.ELECTRICAL_MEASUREMENT_AC_CURRENT_MULTIPLIER_KEY = "_electrical_measurement_ac_current_multiplier"
+zigbee_constants.ELECTRICAL_MEASUREMENT_AC_VOLTAGE_DIVISOR_KEY = "_electrical_measurement_ac_voltage_divisor"
+zigbee_constants.ELECTRICAL_MEASUREMENT_AC_CURRENT_DIVISOR_KEY = "_electrical_measurement_ac_current_divisor"


I'd feel more comfortable if you just made these strings local to this driver rather than writing to the zigbee_constants map.

greens · 2026-02-05T20:18:22Z

drivers/SmartThings/zigbee-power-meter/src/frient/utils.lua

+-- Copyright 2025 SmartThings
+--
+-- Licensed under the Apache License, Version 2.0 (the "License");
+-- you may not use this file except in compliance with the License.
+-- You may obtain a copy of the License at
+--
+--     http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.


update this copyright/license statement to the shorter and more concise one

greens · 2026-02-05T20:19:15Z

drivers/SmartThings/zigbee-power-meter/src/frient/init.lua

+local ATTRIBUTES = {
+  {
+    cluster = SimpleMetering.ID,
+    attribute = SimpleMetering.attributes.CurrentSummationDelivered.ID,
+    minimum_interval = 5,
+    maximum_interval = 3600,
+    data_type = data_types.Uint48,
+    reportable_change = 1
+  },
+  {
+    cluster = SimpleMetering.ID,
+    attribute = SimpleMetering.attributes.InstantaneousDemand.ID,
+    minimum_interval = 5,
+    maximum_interval = 3600,
+    data_type = data_types.Int24,
+    reportable_change = 1
+  }
+}


both the same as the defaults as far as I can tell

greens · 2026-02-05T20:20:43Z

drivers/SmartThings/zigbee-power-meter/src/frient/init.lua

+  device.thread:call_with_delay(5, function()
+    do_refresh(self, device)
+  end)


Why do you need to call refresh 5 seconds after you just called it at the top of this function?

greens · 2026-02-05T20:22:02Z

drivers/SmartThings/zigbee-power-meter/src/frient/init.lua

  device:configure()
+
+  if device:supports_capability(capabilities.battery) then
+    device:send(PowerConfiguration.attributes.BatteryVoltage:configure_reporting(device, 30, 21600, 1))


is this not handled by device:configure already?

greens · 2026-02-05T20:23:55Z

drivers/SmartThings/zigbee-power-meter/src/frient/init.lua

+    device:send(PowerConfiguration.attributes.BatteryVoltage:configure_reporting(device, 30, 21600, 1))
+  end
+  for _, fingerprint in ipairs(ZIGBEE_POWER_METER_FINGERPRINTS) do
+    if device:get_model() == fingerprint.model and fingerprint.preferences then


can't you just check for the existence of the preference itself rather than including a separate boolean in the fingerprints map?

greens · 2026-02-05T20:25:28Z

drivers/SmartThings/zigbee-power-meter/src/frient/init.lua

+local function instantaneous_demand_handler(driver, device, value, zb_rx)
+  local raw_value = value.value
+  --- demand = demand received * Multipler/Divisor
+  local multiplier = device:get_field(zigbee_constants.SIMPLE_METERING_MULTIPLIER_KEY) or 1
+  local divisor = device:get_field(zigbee_constants.SIMPLE_METERING_DIVISOR_KEY) or SIMPLE_METERING_DEFAULT_DIVISOR
+  if raw_value < -8388607 or raw_value >= 8388607 then
+    raw_value = 0
+  end
+
+  raw_value = raw_value * multiplier / divisor * 1000
+
+  local raw_value_watts = raw_value
+  device:emit_event_for_endpoint(zb_rx.address_header.src_endpoint.value, capabilities.powerMeter.power({ value = raw_value_watts, unit = "W" }))
+end


This also seems functionally the same as the default behavior.

greens · 2026-02-05T20:25:59Z

drivers/SmartThings/zigbee-power-meter/src/frient/init.lua

+  device:emit_event_for_endpoint(zb_rx.address_header.src_endpoint.value, capabilities.powerMeter.power({ value = raw_value_watts, unit = "W" }))
+end
+
+local function energy_meter_handler(driver, device, value, zb_rx)


what's different between this handler and the sub-driver's version?

greens · 2026-02-05T20:26:40Z

drivers/SmartThings/zigbee-power-meter/src/frient/init.lua

+
+local device_init = function(self, device)
+  for _, fingerprint in ipairs(ZIGBEE_POWER_METER_FINGERPRINTS) do
+    if device:get_model() == fingerprint.model and fingerprint.battery then


you can just check for whether MIN_BAT exists rather than use the extra boolean

add driver

bfabc01

removed unused variables

115fa8e

marcintyminski changed the title ~~add driver~~ add driver to frient EMI devices Jan 27, 2026

KKlimczukS requested a review from greens February 4, 2026 10:43

greens changed the title ~~add driver to frient EMI devices~~ WWSTCERT-10228/10231/10234 add driver to frient EMI devices Feb 5, 2026

greens requested review from pegor-karoglanian and wkhenon February 5, 2026 18:41

greens changed the title ~~WWSTCERT-10228/10231/10234 add driver to frient EMI devices~~ WWSTCERT-10225/10228/10231/10234 add driver to frient EMI devices Feb 5, 2026

greens reviewed Feb 5, 2026

View reviewed changes

pegor-karoglanian reviewed Feb 5, 2026

View reviewed changes

greens reviewed Feb 5, 2026

View reviewed changes

marcintyminski added 2 commits February 6, 2026 07:56

Merge branch 'SmartThingsCommunity:main' into Add-support-to-frient-EMIs

6b442b4

Merge branch 'SmartThingsCommunity:main' into Add-support-to-frient-EMIs

9b2dc97

KKlimczukS requested a review from greens February 9, 2026 08:51

Conversation

marcintyminski commented Jan 26, 2026

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

github-actions bot commented Jan 26, 2026

Uh oh!

github-actions bot commented Jan 26, 2026

Uh oh!

github-actions bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pegor-karoglanian Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 26, 2026 •

edited

Loading

github-actions bot commented Jan 26, 2026 •

edited

Loading

pegor-karoglanian Feb 5, 2026 •

edited

Loading

greens Feb 5, 2026 •

edited

Loading

greens Feb 5, 2026 •

edited

Loading