[3.0] Bots - reduce topic view updates#9150
Merged
jdarwood007 merged 1 commit intoSimpleMachines:release-3.0from Mar 14, 2026
Merged
[3.0] Bots - reduce topic view updates#9150jdarwood007 merged 1 commit intoSimpleMachines:release-3.0from
jdarwood007 merged 1 commit intoSimpleMachines:release-3.0from
Conversation
Signed-off-by: Shawn Bulen <bulens@pacbell.net>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3.0 version of #9128 - More discussion may be found there.
This PR aims to minimize I/O during a bot attack by eliminating the tracking of guest & bot views in the smf_topics record. Note this counter is incremented under all circumstances, and causes yet another I/O during bot attacks.
An option is added, allowing the user to turn this behavior on or off. Users may wish to disable this only during high-CPU bot attacks.
I've been running this code on my prod forum with no issues.
For more discussion see:
https://www.simplemachines.org/community/index.php?topic=592442.0