[2.1] Bots - reduce permissions queries#9124
Merged
jdarwood007 merged 2 commits intoSimpleMachines:release-2.1from Mar 14, 2026
Merged
[2.1] Bots - reduce permissions queries#9124jdarwood007 merged 2 commits intoSimpleMachines:release-2.1from
jdarwood007 merged 2 commits intoSimpleMachines:release-2.1from
Conversation
Signed-off-by: Shawn Bulen <bulens@pacbell.net>
Member
|
@sbulen Do you have the related updates for 3.0 on this PR? |
Contributor
Author
|
I was going to add 3.0 versions once the 2.1 ones were approved. Trying to avoid duplication of rework, etc. Some of these are a little higher risk than others. This one, I think, is a no-brainer. Pretty substantial reduction in queries, no loss of functionality. |
Member
|
I've tagged this on the 3.0 project with the 2.1.8 milestone. Will test later. |
Sesquipedalian
requested changes
Mar 12, 2026
Signed-off-by: Shawn Bulen <bulens@pacbell.net>
Contributor
Author
|
Requested changes made. |
jdarwood007
approved these changes
Mar 13, 2026
Member
jdarwood007
left a comment
jdarwood007
left a comment
There was a problem hiding this comment.
Approved, will wait for a 3.0 version before I merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to minimize unnecessary I/O by not doing moderator permissions lookups for guests and bots, who we already know will not have any moderator or admin privileges... This can add a lot of unnecessary permissions queries during normal operation, but especially during bot attacks.
I've been running this code on my prod forum with no issues.
If this is approved, I can submit a 3.0 version.
For more discussion see:
https://www.simplemachines.org/community/index.php?topic=592442.0
Feedback welcome.