Conversation
Contributor
Author
|
Important note: I wasn't sure whether to accept |
Contributor
|
Since we're examining AA parsing, should we consider using an include-list for valid amino acids, instead of just checking ascii alpha? I feel like there was a comment somewhere about just using u8 for now instead of having a proper AA type, but I don't think that needs to preclude us from parsing more strictly. |
hwchen
reviewed
Mar 10, 2026
hwchen
approved these changes
Mar 10, 2026
Contributor
Author
|
The reason I didn't include an AA list is because every single letter is some kind of AA code. Some are ambiguous and some are uncommon, but all letters are potentially valid. |
(also refactor two dereferences into one reference destructuring)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Ravna ran into an issue where invalid data wasn't caught early, resulting in much head-scratching: Two fastas had been concatenated without a newline between them, but
FastaParser::<ProteinSequence>didn't catch that. This fixes that, as well as the fact that proteins don't strip out spaces, even though the tests imply that they should.