Skip to content

Fix corretto25-jdk install issues#580

Open
h143570 wants to merge 1 commit intoScoopInstaller:masterfrom
h143570:fix/corretto25-extract-dir
Open

Fix corretto25-jdk install issues#580
h143570 wants to merge 1 commit intoScoopInstaller:masterfrom
h143570:fix/corretto25-extract-dir

Conversation

@h143570
Copy link
Contributor

@h143570 h143570 commented Feb 6, 2026

Fixed the install issues with corretto25-jdk. Updated the script to use the extraction_dir format used by previous working versions of the script.

Fixing Issue #575

Summary by CodeRabbit

  • Chores
    • Updated JDK Corretto 25 build configuration and versioning parameters.

@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

Walkthrough

Updates the Corretto JDK 25 build manifest by hardcoding the build version from 10 in the extract directory path and replacing a template variable with a buildVersion placeholder in the autoupdate configuration.

Changes

Cohort / File(s) Summary
JDK Build Configuration
bucket/corretto25-jdk.json
Modified extract_dir template from dynamic $matchBuild to hardcoded version "10"; updated autoupdate.extract_dir template variable from $matchBuild to $buildVersion.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • PR #567: Updates the same Corretto JDK 25 manifest with extract_dir and autoupdate.extract_dir template configuration.

Suggested labels

review-needed

Suggested reviewers

  • se35710

Poem

🐰 A version number is set in stone,
Ten becomes the home jdk's known,
BuildVersion templates now align,
Corretto's manifest shines so fine! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description does not follow the required template structure and is missing mandatory sections. Add a reference to the related issue using 'Closes #575' or 'Relates to #575' at the beginning, and include the checkbox confirming you have read the Contributing Guide as specified in the template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix corretto25-jdk install issues' directly and clearly describes the main change in the PR, which fixes installation issues with corretto25-jdk by updating extract_dir values.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

All changes look good.

Wait for review from human collaborators.

corretto25-jdk

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant