General MTMD Improvements & Cleanup#1351
Merged
martindevans merged 2 commits intoSciSharp:masterfrom Mar 8, 2026
Merged
Conversation
- Moved `CountPositions`/`CountTokens` to be instance methods on `SafeMtmdInputChunks` - Better exceptions in `LoadFromFile`/`LoadFromFileAsync` (checking for file readability etc) - Using safe handles instead of raw pointers in many places. In turn removed lots of uses of `DangerousGetHandle()` - Accepting spans instead of arrays in `FromRgbBytes`/`FromAudioSamples` - Added more doc comments on mtmd methods
|
Please consider these suggestions. Currently, the architecture of working with embeds is not done correctly. Embed - It has nothing to do with the model, but just a resource for executor's. |
Member
Author
|
I did notice the way embeds is handled is a bit weird, but changing that is too much for a cleanup/refactoring PR like this. I'll probably come back to look at that in the future, but I'll have to coordinate with @SignalRT about that. |
SignalRT
reviewed
Mar 7, 2026
Collaborator
SignalRT
left a comment
SignalRT
left a comment
There was a problem hiding this comment.
This is my main doubt about this set of changes
Member
Author
|
@SignalRT Anything else you wanted to address, or is this ready to merge? |
Collaborator
From my point of view is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CountPositions/CountTokensto be instance methods onSafeMtmdInputChunksLoadFromFile/LoadFromFileAsync(checking for file readability etc)DangerousGetHandle()FromRgbBytes/FromAudioSamples