Skip to content

Fix flaky unit tests#1350

Merged
martindevans merged 1 commit intoSciSharp:masterfrom
m0nsky:fix/build-race-condition
Mar 4, 2026
Merged

Fix flaky unit tests#1350
martindevans merged 1 commit intoSciSharp:masterfrom
m0nsky:fix/build-race-condition

Conversation

@m0nsky
Copy link
Contributor

@m0nsky m0nsky commented Mar 4, 2026

Changes the following:

  • Fixes a typo (FirstTargetFrameworks -> FirstTargetFramework)
  • Restored WriteLinesToFile (I think this was accidently removed in this commit, as discussed in discord: 4f3f0ed)
  • Now also checks if the deps folder exists, so if release_id.txt gets written after building the project, but we delete the deps folder (but keep the txt file in place), it's still going to re-download and unzip the deps

Ran the tests 8 times on my fork and didn't manage to reproduce the failing tests.

@martindevans martindevans merged commit 81cf9eb into SciSharp:master Mar 4, 2026
8 checks passed
@m0nsky m0nsky deleted the fix/build-race-condition branch March 4, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants