Fix the filtering of attributes validated with SchemaValidations::Validators::NotNilValidator#56
Open
dark-panda wants to merge 1 commit intoSchemaPlus:masterfrom
Conversation
…idators::NotNilValidator This appears to be a special case where the `name` parameter of `#_filter_validation` is set to `SchemaValidations::Validators::NotNilValidator` and the actual name is found in the `:attribute` option in `opts`. Filtering-by-name using the `only`, `except`, etc. configurations see the wrong `name` value in these cases and will not be filtered correctly as a result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, but I wasn't able to get the specs running correctly on my setup,
so I have not included updated specs in the patch.
This appears to be a special case where the
nameparameter of#_filter_validationis set toSchemaValidations::Validators::NotNilValidatorand the actual name is found in the
:attributeoption inopts.Filtering-by-name using the
only,except, etc. configurations seethe wrong
namevalue in these cases and will not be filteredcorrectly as a result.