[SYNPY-1777] changed logging to only be when schema name changes#1331
Merged
andrewelamb merged 1 commit intodevelopfrom Feb 27, 2026
Merged
[SYNPY-1777] changed logging to only be when schema name changes#1331andrewelamb merged 1 commit intodevelopfrom
andrewelamb merged 1 commit intodevelopfrom
Conversation
linglp
approved these changes
Feb 27, 2026
Contributor
linglp
left a comment
linglp
left a comment
There was a problem hiding this comment.
Thanks for the quick fix. LGTM
thomasyu888
changed the title
thomasyu888
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When using the
fix_schema_namesparameter inregister_json_schema, the name change is logged, even if it doesn't actually change. For example:Solution:
This logging only happens if the new name actuallt changes from the old name.