[SYNPY-1765] Remove project id arg from create_record_based_curator_task

[andrewelamb]

Problem:

• create_record_based_metadata_task required both a folder_id and project_id
• The description for record_set_name in create_record_based_metadata_task and for RecordSet needed improvement.

Solution:

• Added project_id_from_entity_id function.
• Use of project_id is deprecated and no longer used. Now project_id is gotten from the folder_id.
• Docstrings have been improved with the provided descriptions in the Jira ticket.
• File based task creation also uses project_id_from_entity_id function

Testing:

• Integration/unit tests for project_id_from_entity_id function
• project_id_from_entity_id function has been patched in existing unit tests for create_record_based_metadata_task

[linglp]

Hi @andrewelamb ! This is looking really close! A few remaining items:

Documentation that needs to be fixed:

• synapseclient/extensions/curator/readme.md see: create_record_based_metadata_task
  *synapsePythonClient/docs/guides/extensions/curator/metadata_curation.md see create_record_based_metadata_task

Also, the projects created by the integration test should have unique names otherwise we might trigger a racing condition.

Also, do you think project_id_from_entity_id belongs in a util module?

[andrewelamb]

Also, do you think project_id_from_entity_id belongs in a util module?

I'm happy with this. Do you have a suggested location? synapseclient/core/utils.py ?

[linglp]

Also, do you think project_id_from_entity_id belongs in a util module?

I'm happy with this. Do you have a suggested location? synapseclient/core/utils.py ?

How about creating a util module for the curator extension, since only the curator extension needs it at the moment

[linglp]

I am a bit curious why you picked 1000 as the magic number? should we also encode that on top of the Python file?

[andrewelamb]

Yeah, that's a good question. I figured it was a big enough number that there's no way a DCC would actually nest folders to that degree, but was also small enough that if there was actually something wrong with Synapse it wouldn't loop forever. I'm open to changing it, though!

I can set it as a global.

[linglp]

LGTM! Thanks for the changes.