Refactor sendFeedback utility and add ShareE2EEHistory command#296
Merged
Just-Insane merged 6 commits intoSableClient:devfrom Mar 16, 2026
Merged
Refactor sendFeedback utility and add ShareE2EEHistory command#296Just-Insane merged 6 commits intoSableClient:devfrom
Just-Insane merged 6 commits intoSableClient:devfrom
Conversation
…for improved error management
Contributor
|
You mention |
Contributor
Author
Contributor
|
LGTM! Once this gets some testing in, we can remove the gate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This pull request refactors the feedback mechanism for command execution in
useCommands.tsby replacing multiple inline implementations of feedback messaging with a centralizedsendFeedbackutility function. This change improves code maintainability and consistency. Additionally, a new experimental command is introduced.Command feedback refactoring:
sendFeedbackimplementations with calls to the sharedsendFeedbackutility function, standardizing feedback messages across commands and reducing code duplication. (src/app/hooks/useCommands.ts)Code cleanup:
MatrixEventsince feedback messaging is now handled by the utility function. (src/app/hooks/useCommands.ts)New command addition:
ShareE2EEHistoryto theCommandenum. (src/app/hooks/useCommands.ts)see matrix-org/matrix-spec-proposals#4268
Type of change
Checklist: