Skip to content

feat: edit file description#282

Merged
Just-Insane merged 10 commits intoSableClient:devfrom
nushea:Edit-file-body
Mar 16, 2026
Merged

feat: edit file description#282
Just-Insane merged 10 commits intoSableClient:devfrom
nushea:Edit-file-body

Conversation

@nushea
Copy link
Contributor

@nushea nushea commented Mar 15, 2026

Description

Added the ability to edit one's file descriptions

Additionally changed the UX for images and video rendering.
Now Idle or blurred images/videos can be loaded by clicking anywhere on the image/video, not just in the small buttons.
Changed the behavior of videos to not autoplay on load as previously when you had a Watch option it was usually blurred due to it not being fully loaded, not offering you the chance to see the thumbnail before starting the video.

(view of the editing of a file description with the inline setting)
image

(hovering an image/video with your mouse while it is unblurred now has a button to blur it)
image

(hovering over a blurred image, with the text changed to Spoilered as now it will display the spoiler reason within that false button, presumably, i have never seen an image with a spoiler reason but the logic is just how it worked previously with tooltips but more clearly labeled)
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@nushea nushea requested a review from a team March 15, 2026 07:43
@nushea nushea changed the title Edit file body feat: edit file description Mar 15, 2026
@dozro
Copy link
Contributor

dozro commented Mar 15, 2026

i noticed that your pr changes how the editor is displayed

the dev branch:

Screenshot 2026-03-16 at 00 07 57

your change:

Screenshot 2026-03-16 at 00 09 45

is that intentional?

@nushea
Copy link
Contributor Author

nushea commented Mar 15, 2026

i noticed that your pr changes how the editor is displayed

the dev branch:
Screenshot 2026-03-16 at 00 07 57

your change:
Screenshot 2026-03-16 at 00 09 45

is that intentional?

yes this is caused by the one line change in src/app/styles/overrides/Composer.css.ts that was intended to fix min-width 100% causing the inline editor to spill, when i made that fix i was using an older version of sable however and it seems to have been fixed by something else. This change was initially made on a branch i have since deleted, i am going to revert that one line change because i cannot recreate the spilling right now

(like it now works well w my tests with the line reverted per this example)
image

@dozro
Copy link
Contributor

dozro commented Mar 15, 2026

Should be okay now. Thanks :)

@Just-Insane Just-Insane added this pull request to the merge queue Mar 16, 2026
Merged via the queue into SableClient:dev with commit 85b0da3 Mar 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants