Skip to content

IFDM-128: fix to the Retirement calculator#85

Merged
imonroe merged 4 commits into1.xfrom
IFDM-128
Apr 2, 2026
Merged

IFDM-128: fix to the Retirement calculator#85
imonroe merged 4 commits into1.xfrom
IFDM-128

Conversation

@jenbreese
Copy link
Copy Markdown
Collaborator

@jenbreese jenbreese commented Mar 30, 2026

READY FOR REVIEW

Summary

  • Fixup to the calculations as noted in ticket
  • Made the numbers stay when from Required balance to Annual Savings tab.
  • Reset the numbers going from Annual Savings back to Required Balance.

Review By (Date)

  • soon

Criticality

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to...
  3. Verify...

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

Copy link
Copy Markdown
Collaborator

@imonroe imonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@imonroe imonroe merged commit 7e906bd into 1.x Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants