Skip to content

verify: fail if the upward adjacency limit is exceeded #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cwsmith wants to merge 3 commits into
base: develop
Choose a base branch
from
+14 −10
Open

verify: fail if the upward adjacency limit is exceeded #529

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f2272c
verify: fail if the upward adjacency limit is exceeded
cwsmith Feb 10, 2023
c41076b
MDS_SET_MAX header
cwsmith Feb 15, 2026
643d635
specify header dir
cwsmith Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions apf/apfVerify.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include <pcu_util.h>
#include <lionPrint.h>
#include "stdlib.h" // malloc
#include "mds/mds_config.h" //MDS_SET_MAX

namespace apf {

Expand Down Expand Up @@ -84,6 +85,18 @@ static void verifyUp(Mesh* m, UpwardCounts& guc,
m->getUp(e, up);
int upwardCount = up.n;

/* this is here for some spiderwebby simmetrix meshes */
if (upwardCount >= 200) {
std::stringstream ss;
ss << "warning: entity of type " << m->getType(e)
<< " at " << getLinearCentroid(m, e) << " has "
<< upwardCount << " upward adjacencies\n";
// use a stringstream to prevent output from different procs mixing
std::string s = ss.str();
lion_eprint(1,"%s",s.c_str());
PCU_ALWAYS_ASSERT(upwardCount < MDS_SET_MAX);
}

/* check for duplicates in the upward list */
for (int i = 0; i < upwardCount; ++i)
for (int j = i + 1; j < upwardCount; ++j)
Expand Down Expand Up @@ -169,16 +182,7 @@ static void verifyUp(Mesh* m, UpwardCounts& guc,
if (!adjacentToUpwardGhost && abort_on_error)
fail(s.c_str());
}
/* this is here for some spiderwebby simmetrix meshes */
if (upwardCount >= 200) {
std::stringstream ss;
ss << "warning: entity of type " << m->getType(e)
<< " at " << getLinearCentroid(m, e) << " has "
<< upwardCount << " upward adjacencies\n";
// use a stringstream to prevent output from different procs mixing
std::string s = ss.str();
lion_eprint(1,"%s",s.c_str());
}

}

static void verifyResidence(Mesh* m, MeshEntity* e)
Expand Down