Skip to content

fix: report exhaustion for Stoppable and Skippable#868

Merged
yara-blue merged 2 commits intomasterfrom
fix/stop-skip-exhaustion
Mar 22, 2026
Merged

fix: report exhaustion for Stoppable and Skippable#868
yara-blue merged 2 commits intomasterfrom
fix/stop-skip-exhaustion

Conversation

@roderickvd
Copy link
Member

When a source was stopped or skipped, Stoppable/Skippable continued to report a non-zero current_span_len(), so is_exhausted(). This caused queue to incorrectly bootstrap the mixers UniformSourceIterator with the old instead of the new sample rate.

Fixes what @sandreas reported in #853, although it's an issue distinct from get_pos().

@yara-blue
Copy link
Member

new tests nice!

@yara-blue yara-blue merged commit 76f8ba7 into master Mar 22, 2026
3 checks passed
@sandreas
Copy link

@roderickvd

Thank you very much, I can now report, that the problems seem to be fixed. I tried a sample with my Test SineWave followed by the low samplerate m4b file and everything works as expected. Here and there I get a "buffer overrun/underrun" message, but the playback continues.

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants