fix: report exhaustion for Stoppable and Skippable#868
Merged
Conversation
Member
|
new tests nice! |
|
Thank you very much, I can now report, that the problems seem to be fixed. I tried a sample with my Test SineWave followed by the low samplerate m4b file and everything works as expected. Here and there I get a "buffer overrun/underrun" message, but the playback continues. Thank you very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a source was stopped or skipped,
Stoppable/Skippablecontinued to report a non-zerocurrent_span_len(), sois_exhausted(). This causedqueueto incorrectly bootstrap the mixersUniformSourceIteratorwith the old instead of the new sample rate.Fixes what @sandreas reported in #853, although it's an issue distinct from
get_pos().