rust: kernel: uaccess: mark UserSliceReader methods inline#1147
Open
antonio-hickey wants to merge 1 commit intoRust-for-Linux:rust-nextfrom
Open
rust: kernel: uaccess: mark UserSliceReader methods inline#1147antonio-hickey wants to merge 1 commit intoRust-for-Linux:rust-nextfrom
antonio-hickey wants to merge 1 commit intoRust-for-Linux:rust-nextfrom
Conversation
KunWuChan
reviewed
Mar 19, 2025
KunWuChan
left a comment
KunWuChan
left a comment
There was a problem hiding this comment.
Reviewed-by: Kunwu Chan kunwu.chan@hotmail.com
Member
|
Could you please send the review tag to the mailing list? We don't use GitHub PRs anymore nor monitor them for tags. Thanks! |
ojeda
force-pushed
the
rust-next
branch
5 times, most recently
from
bfc3cd8 to
a3b2347
Compare
ojeda
force-pushed
the
rust-next
branch
3 times, most recently
from
5d132fa to
3b83f5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you build the kernel using the llvm-19.1.4-rust-1.83.0-x86_64
toolchain provided by kernel.org with ARCH=x86_64, the following symbols
are generated:
$nm vmlinux | grep ' _R'.*UserSliceReader | rustfilt
ffffffff817c3320 T kernel::uaccess::UserSliceReader::read_slice
ffffffff817c32b0 T kernel::uaccess::UserSliceReader::read_raw
However, these Rust symbols are trivial wrappers around the functions
copy_from_user, _copy_from_user respectively. It doesn't
make sense to go through a trivial wrapper for these functions, so mark
them inline.
After applying this patch, the above command will produce no output.