Enforce todo-gated completion for orchestrator mode#11436
Open
0xMink wants to merge 1 commit intoRooCodeInc:mainfrom
Open
Enforce todo-gated completion for orchestrator mode#114360xMink wants to merge 1 commit intoRooCodeInc:mainfrom
0xMink wants to merge 1 commit intoRooCodeInc:mainfrom
Conversation
Orchestrator mode can prematurely complete tasks when context condensation causes the model to lose track of outstanding work. Force preventCompletionWithOpenTodos for orchestrator mode regardless of the user setting. Also require a todo list to exist before orchestrator completion is allowed — completion without a plan is structurally premature.
0xMink
requested review from
cte,
daniel-lxs,
hannesrudolph,
jr and
mrubens
as code owners
dosubot
bot
added
size:L
Contributor
Reviewed the changes to Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11435
preventCompletionWithOpenTodos = truefor orchestrator mode regardless of user settingCompanion to #11434 which addresses the visibility side (todo list in system prompt).
Test Plan
task.ask("completion_result")not reached