fix: inject thinking param for OpenAI-compatible APIs with reasoning_effort#11397
Draft
roomote[bot] wants to merge 1 commit intomainfrom
Draft
fix: inject thinking param for OpenAI-compatible APIs with reasoning_effort#11397roomote[bot] wants to merge 1 commit intomainfrom
roomote[bot] wants to merge 1 commit intomainfrom
Conversation
…effort
When reasoning_effort is set, OpenAI-compatible APIs like VolcEngine
default "thinking" to "disabled", causing a 400 error. This adds a
fetch wrapper that injects thinking: { type: "enabled" } into
request bodies that contain reasoning_effort but lack a thinking field.
Standard OpenAI endpoints silently ignore unknown body fields,
so this is safe for all OpenAI-compatible providers.
Closes #11395
Contributor
Author
Review complete. No issues found. The fetch wrapper approach is clean, well-scoped, and handles edge cases properly. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #11395
Description
This PR attempts to address Issue #11395. When using the OpenAI-compatible provider with APIs like VolcEngine (
ark-code-latest), enabling "Reasoning Effort" sendsreasoning_effortin the request body but does NOT send athinkingparameter. VolcEngine's API defaultsthinkingtodisabledwhen omitted, and the combinationreasoning_effort: "high"+thinking: disabledis rejected as HTTP 400.How it works:
A custom
fetchwrapper (createThinkingAwareFetch) is passed to thecreateOpenAIprovider factory. For any request body that already containsreasoning_effortbut lacks athinkingfield, the wrapper injectsthinking: { type: "enabled" }. Standard OpenAI endpoints silently ignore unknown body fields, so this is safe for all OpenAI-compatible providers.Key details:
createOpenAIpath)thinkingfield if one is already presentTest Procedure
createThinkingAwareFetchcovering:thinkingwhenreasoning_effortis presentthinkingwhenreasoning_effortis absentthinkingparameterfetchis passed tocreateOpenAIopenai.spec.tspassRun tests:
cd src && npx vitest run api/providers/__tests__/openai.spec.tsPre-Submission Checklist
Documentation Updates
Additional Notes
Feedback and guidance are welcome.