Open
Conversation
Made perlcrit happy
Changed .perlcritic to not force stupid rules
Changed $hash{'key'} to $hash{key} even if I disabled TooMuchCode::ProhibitDuplicateLiteral because it is better style
Fixed serious bug in all affected code:
eval "use $class" will ALWAYS return undef!
changed to use Class::Load in affected code
detected 78 other uses of this, including in test - not fixed
Commented windows out in t/file.t GitHub is confusing me ... :-)
Rex::Hardware::Network depends on Rex::Commands::Gather but was 'use Rex::Hardware::Network' in Gather
caused by circular Rex::Hardware::Network
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Alpine Linux + syntax fixes
Made perlcrit happy
Changed .perlcritic to not force stupid rules
Changed $hash{'key'} to $hash{key} even if I disabled TooMuchCode::ProhibitDuplicateLiteral because it is better style
Fixed serious bug in all affected code:
eval "use $class" will ALWAYS return undef!
changed to use Class::Load in affected code
detected 78 other uses of this, including in test - not fixed
Other serious bugs discovered at test:
I added 'use strict' that caused tests to fail - will fix it
This pull request proposes to fix # by .
Checklist towards merging