[Observability] Include const-return methods in --trace-compile as logs only#277
Open
NHDaly wants to merge 1 commit intov1.10.2+RAIfrom
Open
[Observability] Include const-return methods in --trace-compile as logs only#277NHDaly wants to merge 1 commit intov1.10.2+RAIfrom
--trace-compile as logs only#277NHDaly wants to merge 1 commit intov1.10.2+RAIfrom
Conversation
These are never compiled by LLVM, but we want to log them since they are inferred / compiled by our own compiler. Change to *only log* instead of emitting precompile Note that this only emits 0.0 seconds, so not quite all of what we want.
kpamnany
force-pushed
the
nhd-trace-const-return--no-precompile
branch
from
9a73202 to
b6637c5
Compare
kpamnany
changed the title
--trace-compile (as LOGS ONLY)--trace-compile as logs only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
These are never compiled by LLVM, but we want to log them since they are inferred / compiled by our own compiler.
Change to only log instead of emitting precompile
Note that this only emits 0.0 seconds, so not quite all of what we want.
Checklist
Requirements for merging:
--trace-compileignores inferred const-return Methods JuliaLang/julia#58482port-to-*labels that don't apply.