fix: add guard for owner_id nil dereference#2138
Merged
MichaelMraka merged 1 commit intoRedHatInsights:masterfrom Mar 31, 2026
Merged
fix: add guard for owner_id nil dereference#2138MichaelMraka merged 1 commit intoRedHatInsights:masterfrom
MichaelMraka merged 1 commit intoRedHatInsights:masterfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a nil-check guard and warning log before using SystemProfile.OwnerID in hostTemplate to prevent nil-pointer dereferences when assigning templates. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
SC Environment Impact AssessmentOverall Impact: ⚪ NONE No SC Environment-specific impacts detected in this PR. What was checkedThis PR was automatically scanned for:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2138 +/- ##
==========================================
- Coverage 59.18% 59.16% -0.03%
==========================================
Files 134 134
Lines 8625 8628 +3
==========================================
Hits 5105 5105
- Misses 2985 2987 +2
- Partials 535 536 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichaelMraka
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit changed
OwnerIDto a pointer. This adds a guard for that in/listener/upload.goto prevent nil pointer dereferences.Summary by Sourcery
Bug Fixes: