Update module github.com/lib/pq to v1.12.0#2136
Conversation
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
c3f3149 to
f50e88c
Compare
Reviewer's guide (collapsed on small PRs)Reviewer's GuideBumps the PostgreSQL driver dependency github.com/lib/pq from v1.11.2 to v1.12.0 in go.mod (and go.sum), pulling in upstream feature, deprecation, and bugfix changes while leaving application code untouched. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
SC Environment Impact AssessmentOverall Impact: ⚪ NONE No SC Environment-specific impacts detected in this PR. What was checkedThis PR was automatically scanned for:
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Given the upstream note that the next lib/pq release may change the default
sslmodefromrequiretoprefer, it would be good to scan existing DSNs and explicitly setsslmodewhere you rely on current defaults to avoid subtle behavioral changes in a future bump. - Since
CopyIn/CopyInToSchemaare now deprecated, check whether this codebase uses them and, if so, plan a follow-up PR to migrate those call sites to rawCOPY ... FROM STDINstatements as suggested in the changelog.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Given the upstream note that the next lib/pq release may change the default `sslmode` from `require` to `prefer`, it would be good to scan existing DSNs and explicitly set `sslmode` where you rely on current defaults to avoid subtle behavioral changes in a future bump.
- Since `CopyIn`/`CopyInToSchema` are now deprecated, check whether this codebase uses them and, if so, plan a follow-up PR to migrate those call sites to raw `COPY ... FROM STDIN` statements as suggested in the changelog.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2136 +/- ##
=======================================
Coverage 59.18% 59.18%
=======================================
Files 134 134
Lines 8624 8624
=======================================
Hits 5104 5104
Misses 2985 2985
Partials 535 535
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR contains the following updates:
v1.11.2->v1.12.0Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
lib/pq (github.com/lib/pq)
v1.12.0Compare Source
The next release may change the default sslmode from
requiretoprefer.See #1271 for details.
CopyIn()andCopyInToSchema()have been marked as deprecated. These aresimple query builders and not needed for
COPY [..] FROM STDINsupport (whichis not deprecated). (#1279)
Features
Support protocol 3.2, and the
min_protocol_versionandmax_protocol_versionDSN parameters (#1258).Support
sslmode=preferandsslmode=allow(#1270).Support
ssl_min_protocol_versionandssl_max_protocol_version(#1277).Support connection service file to load connection details (#1285).
Support
sslrootcert=systemand use~/.postgresql/root.crtas the defaultvalue of sslrootcert (#1280, #1281).
Add a new
pqerrorpackage with PostgreSQL error codes (#1275).For example, to test if an error is a UNIQUE constraint violation:
To make this a bit more convenient, it also adds a
pq.As()function:Fixes
Fix SSL key permission check to allow modes stricter than 0600/0640#1265 (#1265).
Fix Hstore to work with binary parameters (#1278).
Clearer error when starting a new query while pq is still processing another
query (#1272).
Send intermediate CAs with client certificates, so they can be signed by an
intermediate CA (#1267).
Use
time.UTCfor UTC aliases such asEtc/UTC(#1282).Configuration
📅 Schedule: Branch creation - Between 03:00 AM and 10:59 AM, only on Monday ( * 3-10 * * 1 ) in timezone Europe/Prague, Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.
Summary by Sourcery
Build: