Update Documentation for Routable Protocol#84
Open
viewDidAppear wants to merge 1 commit intoReSwift:masterfrom
Open
Update Documentation for Routable Protocol#84viewDidAppear wants to merge 1 commit intoReSwift:masterfrom
viewDidAppear wants to merge 1 commit intoReSwift:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
=======================================
Coverage 80.28% 80.28%
=======================================
Files 5 5
Lines 208 208
=======================================
Hits 167 167
Misses 41 41
Continue to review full report at Codecov.
|
Contributor
|
@hlineholm Since you were working on the protocol last, do you have time to incorporate docstrings like this? E.g. rebase this PR and adjust? |
Contributor
|
Yes @DivineDominion if a get a slot in my calendar I will. Not my highest priority at the moment though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change has been made to take advantage of the
///header-doc functionality in Xcode. Holding down Option while clicking on the method signatures of the Routable protocol will now provide further insight as to what needs to be supplied, and how it must be implemented to ensurefatalError()does not get triggered at runtime.