Open
Conversation
Jutho
reviewed
Mar 16, 2026
Jutho
reviewed
Mar 16, 2026
Jutho
reviewed
Mar 16, 2026
| @algdef Jacobi | ||
|
|
||
| """ | ||
| SVDPolar(; [driver], kwargs...) |
Member
There was a problem hiding this comment.
This might become confusing with PolarViaSVD 😄 .
Member
Author
There was a problem hiding this comment.
Do you think it would make sense to make this SVDViaPolar instead? I'd definitely also be okay with that.
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #178 to improve on #176.
This consists of quite a few more opinionated changes that I think are warranted but might not be completely fair.
I have renamed a bunch of the LAPACK-like functions across YALAPACK/YAROCSOLVER/YACUSOLVER in an attempt to make life slightly easier, and simply merge all of the implementations into a single big
@evalloop.In the meantime, I also changed the GLA implementations to actually copy in-place, as this is something that has come up quite a few times already and I think overall this is probably more convenient anyways.
The jacobi-svd algorithm that only worked for LAPACK with
m >= nis now also implemented form < nby making use of the samesvd_via_adjointpattern that was already present in some of the GPU solvers, which is now also shared.I think overall this manages to delete quite a bit of code, but the eval loops are also somewhat hard to follow so I'm not sure if this is all that much "simpler" implementation-wise, but at least it does allow selecting
DivideAndConquerin a driver-agnostic way.