Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
I am surprised this works; I actually moved also the Mooncake tests to |
|
Could it be the custom finite differences method Enzyme is using for fp32? |
|
Anyone have objections to me merging this? |
|
Not really, though as mentioned, I actually moved LQ and QR tests for Mooncake and Enzyme from |
|
Maybe worth testing again if that change of mine was really necessary, or resulting from an underlying problem that I only fixed afterwards? |
|
Let me check that also, then |
|
I see the failures locally too. Maybe we can test both |
|
I am fine with any suggestion. I should probably revisit the QR/LQ tests, since I would think that the eig / svd tests are more sensitive to numerical noise than QR/LQ, so if former manage to work for |
No description provided.