Skip to content

Run trunc tests with Float32 thanks to new Enzyme#187

Open
kshyatt wants to merge 1 commit intomainfrom
ksh/enz32
Open

Run trunc tests with Float32 thanks to new Enzyme#187
kshyatt wants to merge 1 commit intomainfrom
ksh/enz32

Conversation

@kshyatt
Copy link
Member

@kshyatt kshyatt commented Mar 13, 2026

No description provided.

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jutho
Copy link
Member

Jutho commented Mar 15, 2026

I am surprised this works; I actually moved also the Mooncake tests to Float64 after some issues in #180 .

@kshyatt
Copy link
Member Author

kshyatt commented Mar 16, 2026

Could it be the custom finite differences method Enzyme is using for fp32?

@kshyatt
Copy link
Member Author

kshyatt commented Mar 17, 2026

Anyone have objections to me merging this?

@Jutho
Copy link
Member

Jutho commented Mar 17, 2026

Not really, though as mentioned, I actually moved LQ and QR tests for Mooncake and Enzyme from Float32 to Float64, so this is moving in the opposite direction of consistency.

@Jutho
Copy link
Member

Jutho commented Mar 17, 2026

Maybe worth testing again if that change of mine was really necessary, or resulting from an underlying problem that I only fixed afterwards?

@kshyatt
Copy link
Member Author

kshyatt commented Mar 17, 2026

Let me check that also, then

@kshyatt
Copy link
Member Author

kshyatt commented Mar 17, 2026

I see the failures locally too. Maybe we can test both Float32 and Float64 for these Enzyme + truncation tests, considering they now take much less time, and it was previously erroring out in a horrible way?

@Jutho
Copy link
Member

Jutho commented Mar 17, 2026

I am fine with any suggestion. I should probably revisit the QR/LQ tests, since I would think that the eig / svd tests are more sensitive to numerical noise than QR/LQ, so if former manage to work for Float32, then why not the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants