This repository was archived by the owner on Apr 5, 2025. It is now read-only.
Fix voice session destroyed after bot moved#333
Closed
ferrenza wants to merge 2 commits intoPythonistaGuild:mainfrom
Closed
Fix voice session destroyed after bot moved#333ferrenza wants to merge 2 commits intoPythonistaGuild:mainfrom
ferrenza wants to merge 2 commits intoPythonistaGuild:mainfrom
Conversation
When the bot moves channels, the player was being destroyed because the disconnect wait did not account for the brief period between disconnect and reconnect. This commit modifies `_disconnected_wait` to wait for the _reconnecting event and then verifies the current voice state via `guild.me.voice.channel`. If a valid channel is detected, the connection is restored without calling `_destroy()`. This prevents accidental player deletion during channel moves.
When the bot moves channels, the player was being destroyed because the disconnect wait did not account for the brief period between disconnect and reconnect. This commit modifies `_disconnected_wait` to wait for the _reconnecting event and then verifies the current voice state via `guild.me.voice.channel` If a valid channel is detected, the connection is restored without calling `_destroy()` This prevents accidental player deletion during channel moves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the bot moves channels, the player was being destroyed because the disconnect wait did not account for the brief period between disconnect and reconnect. This commit modifies
_disconnected_waitto wait for the_reconnectingevent and then verifies the current voice state viaguild.me.voice.channelIf a valid channel is detected, the connection is restored without calling_destroy()This prevents accidental player deletion during channel moves.Description
This PR fixes an issue where the player was inadvertently destroyed when the bot moved from one voice channel to another. By waiting for
_reconnectingand checkingguild.me.voice.channel, we ensure that a valid reconnect occurs before deciding whether to destroy the player. This prevents the brief disconnect period from prematurely removing the player's session during channel moves.Checklist