feat: introduce stack-allocated PyBuffer#5894
Open
winstxnhdw wants to merge 2 commits intoPyO3:mainfrom
Open
Conversation
winstxnhdw
commented
Mar 19, 2026
| ffi::PyObject_GetBuffer(obj.as_ptr(), ptr::addr_of_mut!((*view_ptr).raw), flags) | ||
| })?; | ||
|
|
||
| // TODO: needs a cleanup strategy — MaybeUninit never drops its contents, so PyBuffer_Release is not currently called. |
Author
There was a problem hiding this comment.
I've left this incomplete for now because I want to hear more opinions on how to handle this.
Because we are using MaybeUninit to initialise Py_buffer, MaybeUninit never drops its contents, so we still need a way to call PyBuffer_Release to prevent a reference leak.
Here are some options I can think of:
- Use a local drop guard holding a raw pointer to the
Py_buffer, released on scope exit/panic - Construct an owned
PyUntypedBufferViewwithPy_buffer::new(), lettingDrophandle release, but this is not zero-cost. - Call
assume_init_drop()orptr::drop_in_place()at the end ofwith()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a pinned stack-allocated
PyUntypedBuffervariant,PyUntypedBufferView.Closes #5836