fix(app): createClientEffect without Effect.either for HTTP errors#8
Merged
skulidropek merged 2 commits intomainfrom Feb 12, 2026
Merged
fix(app): createClientEffect without Effect.either for HTTP errors#8skulidropek merged 2 commits intomainfrom
skulidropek merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes follow-up requirement from PR #6: avoid needing
yield* Effect.either(...)for normal HTTP statuses.Now:
yield* apiClientEffect.POST(...)returns a value for both 2xx and 4xx/5xx defined in the OpenAPI schema.ApiSuccessHttpErrorwith_tag: "HttpError"Changes:
createClientEffectnow returnsClientEffect<Paths>(new exported type).401is returned as value withoutEffect.either.Why:
Effect.eitherjust to access HTTP error values.