(GH-538) Define newtypes for exit_codes fields

[michaeltlombardi]

PR Summary

This change defines two new types:

• ExitCode as a lightweight wrapper around i32 where we can control serialization and deserialization with strings as the serialized format instead of an integer.

• ExitCodesMap as a lightweight wrapper for HashMap<ExitCode, String>. It implements a helper function for determining whether the map is empty or default and defines the default map for exit 0 (success) and 1 (error).

  The ExitCodesMap includes a hand-implementation of JsonSchema to match the canonical JSON Schema, which schemars won't generate from the struct definition.

This change not only enables us to provide the canonical JSON Schema for exit code fields in a reusable way, it also removes the need to maintain a converter function for transforming the exit codes map from HashMap<String, String> to HashMap<i32, String>.

This change also:

• Updates the ResourceManifest and ExtensionManifest structs to use the ExitCodesMap for the exit_codes field.
• Updates the implementations of run_process_async() and invoke_command() to use the new type.
• Removes the now-erroneous convert_hashmap_string_keys_to_i32() function, since the exit codes are correctly typed from deserialization/instance creation.

PR Context

Prior to this change, the exit_codes fields for the resource and extension manifests defined the map of exit codes to their semantic meanings as Option<HashMap<String, String>>.

As part of schema canonicalization, we need to provide a canonical JSON Schema for that object. Unfortunately, because we don't own either the JsonSchema trait or HashMap<T> type, we need to use a newtype wrapper.

[Copilot]

Pull request overview

This pull request introduces strongly-typed newtypes for exit codes to improve type safety, provide canonical JSON Schema generation, and eliminate manual type conversion. The PR defines ExitCode (a wrapper around i32) and ExitCodesMap (a wrapper around HashMap<ExitCode, String>), replacing the previous Option<HashMap<String, String>> approach used in resource and extension manifests.

Changes:

• Introduces ExitCode and ExitCodesMap newtypes with custom serialization, deserialization, and JSON Schema implementations
• Updates ResourceManifest and ExtensionManifest to use ExitCodesMap instead of Option<HashMap<String, String>>
• Removes the convert_hashmap_string_keys_to_i32() helper function, as conversion now happens automatically during deserialization
• Adds comprehensive integration tests for both new types
• Adds localization strings and schema documentation for the exit codes definition

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
lib/dsc-lib/src/types/exit_code.rs	Defines ExitCode newtype with string-based serialization and i32-based internal representation
lib/dsc-lib/src/types/exit_codes_map.rs	Defines ExitCodesMap newtype with custom JSON Schema and helper methods for lookup
lib/dsc-lib/src/types/mod.rs	Exports the new types
lib/dsc-lib/tests/integration/types/exit_code.rs	Comprehensive integration tests for ExitCode covering methods, serde, and traits
lib/dsc-lib/tests/integration/types/exit_code_map.rs	Comprehensive integration tests for ExitCodesMap covering methods, schema, serde, and traits
lib/dsc-lib/tests/integration/types/mod.rs	Adds test module declarations
lib/dsc-lib/src/dscresources/resource_manifest.rs	Updates exit_codes field to use ExitCodesMap
lib/dsc-lib/src/extensions/extension_manifest.rs	Updates exit_codes field to use ExitCodesMap
lib/dsc-lib/src/dscresources/command_resource.rs	Updates invoke_command and run_process_async signatures, removes conversion function
lib/dsc-lib/src/dscerror.rs	Adds InvalidExitCode error variant
lib/dsc-lib/locales/schemas.definitions.yaml	Adds schema documentation for exit codes
lib/dsc-lib/locales/en-us.toml	Adds localization strings for exit codes and removes obsolete key

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.