Implement childcare expense deductions and benefits#540
Implement childcare expense deductions and benefits#540vahid-ahmadi wants to merge 6 commits intomasterfrom
Conversation
Program Review: PR #540 -- Implement Childcare Expense Deductions and BenefitsSource Documents
Critical (Must Fix)
Should Address
Suggestions
PDF Audit Summary
Breakdown by jurisdiction:
Validation Summary
Review Severity: REQUEST_CHANGESThis PR introduces 5 new child care programs with 13 critical issues that must be fixed before merge. The Ontario CARE credit has a systematically wrong rate table and a fundamentally incorrect formula. The BC CCFRI has a $400/month parameter error for preschool-age children. The Alberta subsidy uses unsourced base amounts and an incorrect phase-out model. The federal CCED is the strongest implementation but still has issues with earned income definition, claimant allocation, and non-corroborating references. Per-program assessment:
Next StepsPriority 1 -- Must fix before merge:
To auto-fix issues: |
…fs, tests Critical fixes: - Ontario CARE: fix rate table (+2pp error from duplicate 0.73 at $22,500), rewrite formula to use federal CCED (line 21400), fix income variable - BC CCFRI: fix preschool $145→$545, add kindergarten $320 category, parameterize all hard-coded ages, flatten nested where() to np.select - Alberta: replace unsourced $200/$250 with actual discrete income bracket tables (14 preschool + 10 school-age brackets), remove linear phase-out - Federal CCED: fix all 7 references to cite ITA s.63 + T778, broaden earned income to include self-employment, fix claimant allocation to use total income with deterministic tiebreaker for equal-income case Should-address fixes: - Migrate changelog to towncrier format (changelog.d/540.added.md) - Fix 30 parameter descriptions (trailing periods, active voice) - Add period metadata to 8 parameter files - Remove scope creep (armed forces deduction from deductions_from_total) - Change documentation→reference field on all variable files - Remove np.round() calls, add #page=5 to BC CCFRI PDF references Tests: 797 passing (11 new boundary/allocation tests added) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fixes Applied🔴 Critical Issues Fixed (13/13)
🟡 Should-Address Issues Fixed (15/17)
Verification
Files Changed Summary
Ready for re-review. |
…rences - Ontario CARE: Add 2024 rate schedule with correct income thresholds from ON479-A ($5k steps $40k-$60k, $3.6k steps $60k-$146.4k) - Alberta school-age: Correct 7 bracket amounts ($348/$311/$275/$238/$201/$165/$128) - Alberta preschool: Fix 5 brackets off by $1 ($253/$226/$213/$160/$120) - References: Add subsection detail to ON/CRA citations, BC legislation refs, Alberta regulation refs, specific PDF page anchors - Tests: Fix 9 expected values, add 8 boundary tests (age 6/7, 15/16, disabled 17+, BC $111k, AB age 5) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fixes Applied (Second Pass)🔴 Critical Issues Fixed
🟡 Should-Address Issues Fixed
Verification
Changes by Jurisdiction
Ready for re-review. |
Fixes #533