Saskatchewan Dividend Tax Credit#457
Open
Yaohhhh wants to merge 14 commits intoPolicyEngine:masterfrom
Open
Conversation
PavelMakarchuk
requested changes
Nov 14, 2023
...parameters/gov/provinces/sk/tax/income/credits/dividend_tax_credit/eligible_cal_percent.yaml
Outdated
Show resolved
Hide resolved
...parameters/gov/provinces/sk/tax/income/credits/dividend_tax_credit/eligible_cal_percent.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/tests/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit.yaml
Show resolved
Hide resolved
...les/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/sk_total_taxable_dividends.py
Outdated
Show resolved
Hide resolved
...les/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/sk_total_taxable_dividends.py
Outdated
Show resolved
Hide resolved
...ces/sk/tax/income/credits/sk_dividend_tax_credit/sk_other_than_eligible_taxable_dividends.py
Outdated
Show resolved
Hide resolved
...ces/sk/tax/income/credits/sk_dividend_tax_credit/sk_other_than_eligible_taxable_dividends.py
Outdated
Show resolved
Hide resolved
...ces/sk/tax/income/credits/sk_dividend_tax_credit/sk_other_than_eligible_taxable_dividends.py
Outdated
Show resolved
Hide resolved
...riables/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/sk_dividend_tax_credit.py
Outdated
Show resolved
Hide resolved
...riables/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/sk_dividend_tax_credit.py
Outdated
Show resolved
Hide resolved
.../sk/tax/income/credits/sk_dividend_tax_credit/other_than_eligible_taxable_dividend_income.py
Outdated
Show resolved
Hide resolved
.../sk/tax/income/credits/sk_dividend_tax_credit/other_than_eligible_taxable_dividend_income.py
Outdated
Show resolved
Hide resolved
...iables/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/taxable_dividend_income.py
Outdated
Show resolved
Hide resolved
...iables/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/taxable_dividend_income.py
Outdated
Show resolved
Hide resolved
...iables/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/taxable_dividend_income.py
Outdated
Show resolved
Hide resolved
...parameters/gov/provinces/sk/tax/income/credits/dividend_tax_credit/eligible_cal_percent.yaml
Outdated
Show resolved
Hide resolved
YiweiJ
reviewed
Nov 21, 2023
...parameters/gov/provinces/sk/tax/income/credits/dividend_tax_credit/eligible_cal_percent.yaml
Outdated
Show resolved
Hide resolved
YiweiJ
reviewed
Nov 21, 2023
...gov/provinces/sk/tax/income/credits/dividend_tax_credit/other_than_eligible_cal_percent.yaml
Outdated
Show resolved
Hide resolved
YiweiJ
reviewed
Nov 21, 2023
...parameters/gov/provinces/sk/tax/income/credits/dividend_tax_credit/eligible_cal_percent.yaml
Outdated
Show resolved
Hide resolved
...parameters/gov/provinces/sk/tax/income/credits/dividend_tax_credit/eligible_cal_percent.yaml
Show resolved
Hide resolved
...parameters/gov/provinces/sk/tax/income/credits/dividend_tax_credit/eligible_cal_percent.yaml
Outdated
Show resolved
Hide resolved
...parameters/gov/provinces/sk/tax/income/credits/dividend_tax_credit/eligible_cal_percent.yaml
Outdated
Show resolved
Hide resolved
...riables/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/sk_dividend_tax_credit.py
Outdated
Show resolved
Hide resolved
...riables/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/sk_dividend_tax_credit.py
Outdated
Show resolved
Hide resolved
...riables/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/sk_dividend_tax_credit.py
Outdated
Show resolved
Hide resolved
PavelMakarchuk
approved these changes
Nov 30, 2023
MaxGhenis
requested changes
Dec 1, 2023
policyengine_canada/variables/household/income/individual/taxable_dividend_income.py
Outdated
Show resolved
Hide resolved
..._canada/variables/household/income/individual/other_than_eligible_taxable_dividend_income.py
Outdated
Show resolved
Hide resolved
...rs/gov/provinces/sk/tax/income/credits/dividend_tax_credit/fraction/other_than_eligible.yaml
Show resolved
Hide resolved
policyengine_canada/variables/household/income/individual/tax_exempt_dividend_income.py
Outdated
Show resolved
Hide resolved
policyengine_canada/variables/household/income/individual/taxable_dividend_income.py
Outdated
Show resolved
Hide resolved
PavelMakarchuk
approved these changes
Dec 14, 2023
MaxGhenis
requested changes
Dec 15, 2023
Contributor
MaxGhenis
left a comment
MaxGhenis
left a comment
There was a problem hiding this comment.
What does "other than eligible" mean here? Isn't there just taxable and tax-exempt dividend income? Please name parameters and Python variables consistently if so.
I'm surprised a credit would be based on the difference between taxable and tax-exempt dividends. Please support that with links to the return where lines 12000 and 12010 are defined.
Collaborator
according to this source eligible and other than eligible dividends both refer to taxable dividend income. Eligible dividend income is "generally received from public corporations, earning over $500,000" while other than eligible dividends are received from small businesses (under ~$500,000). Due to the higher corporate rate of larger corporations, eligible dividends are taxed more favorably compared to other than eligible |
PavelMakarchuk
requested changes
Dec 19, 2023
policyengine_canada/variables/household/income/individual/tax_exempt_dividend_income.py
Outdated
Show resolved
Hide resolved
policyengine_canada/variables/household/income/individual/taxable_dividend_income.py
Outdated
Show resolved
Hide resolved
...riables/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/sk_dividend_tax_credit.py
Outdated
Show resolved
Hide resolved
...riables/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/sk_dividend_tax_credit.py
Outdated
Show resolved
Hide resolved
...riables/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/sk_dividend_tax_credit.py
Outdated
Show resolved
Hide resolved
...riables/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/sk_dividend_tax_credit.py
Outdated
Show resolved
Hide resolved
...da/parameters/gov/provinces/sk/tax/income/credits/dividend_tax_credit/fraction/eligible.yaml
Outdated
Show resolved
Hide resolved
Contributor
|
thanks for the context. seems like |
MaxGhenis
reviewed
Dec 22, 2023
...cyengine_canada/variables/household/income/individual/other_than_eligible_dividend_income.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #456