Skip to content

Add a check for VideoSnapshot&& to ImageViewRGB32 conversion #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pifopi wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Add a check for VideoSnapshot&& to ImageViewRGB32 conversion #1131

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
389074a
Add a check for VideoSnapshot&& to ImageViewRGB32 conversion
pifopi Mar 11, 2026
7986db3
Remove --silent
pifopi Mar 12, 2026
a809000
--max-args=50
pifopi Mar 12, 2026
20fa582
--max-procs=0
pifopi Mar 12, 2026
e63f29e
remove //
pifopi Mar 12, 2026
e44b77c
--max-procs=0 --max-args=1
pifopi Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/cpp-ci-serial-programs-base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,20 @@ jobs:
hasDeclaration(cxxConstructorDecl(ofClass(hasName("std::filesystem::path")))),
hasArgument(0, hasType(asString("std::string")))
)
match cxxConstructExpr(
isExpansionInFileMatching("SerialPrograms/"),
hasDeclaration(cxxConstructorDecl(ofClass(hasName("ImageViewRGB32")))),
hasArgument(0, hasType(rValueReferenceType(pointee(hasType(hasName("VideoSnapshot")))))),
unless(hasAncestor(functionDecl(isInline())))
)
EOF

files=$(jq -r '.[].file' SerialPrograms/bin/compile_commands.json)
echo "$files" | xargs --max-args=150 clang-query -p SerialPrograms/bin/ -f query.txt >> output.txt
echo "$files" | xargs --max-procs=0 --max-args=1 clang-query -p SerialPrograms/bin/ -f query.txt >> output.txt
cat output.txt
if grep --silent "Match #" output.txt; then
echo "::error Forbidden std::filesystem::path construction detected!"
if grep "Match #" output.txt; then
echo "::error Forbidden code detected. It can be"
echo "::error - a std::filesystem::path created from std::string. More information https://discord.com/channels/695809740428673034/1462210406616531259/1462567541825339635"
echo "::error - a ImageViewRGB32 created from VideoSnapshot&& that is stored. It is a dangling pointer as nothing hold the data anymore"
exit 1
fi
Loading