feat: horde encounter info #1393
Open
+630
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @DJ-Meyers if you have some spare time could you review this PR? It's about encounters and you recently merged a similar PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding missing Horde Encounter information for XY and ORAS. The information was copied from Bulbapedia's page about the mechanic. Also noticed some minor differences (level max for lombre, and an area labeled "unknown" that can be set as "outside" to match what Bulbapedia refers to it as.)
Some considerations for the future are the differences in encounter between RSE and ORAS are not correctly documented (see Shoal Cave), and some Horde Encounters having a 4-1 split in certain encounters (not sure how to accomplish this with current data structure).
(also sorry for not merging latest master into my branch last time. 😣)